Add Duktape 2.x (and pre-release) support#26
Open
svaarala wants to merge 11 commits intocreationix:masterfrom
Open
Add Duktape 2.x (and pre-release) support#26svaarala wants to merge 11 commits intocreationix:masterfrom
svaarala wants to merge 11 commits intocreationix:masterfrom
Conversation
Owner
|
This is great. I'm still busy with other projects at the moment and greatly appreciate this. |
svaarala
force-pushed
the
duktape-2.x-support
branch
from
65aa8e0 to
6c24b8c
Compare
External buffer is not directly supported however.
svaarala
force-pushed
the
duktape-2.x-support
branch
from
3f772c8 to
f9a66af
Compare
svaarala
force-pushed
the
duktape-2.x-support
branch
from
f9a66af to
2fc56c1
Compare
|
Is this going to be merged anytime soon? I'm thinking of using dukluv in one of my projects but need duktape 2.0 support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Duktape 2.x (and pre-release, i.e.
DUK_VERSION19999).This pull is a work in progress (not intended to be merged yet) and tracks incompatible Duktape 2.x changes so that DukLuv would compile with both Duktape 1.x and 2.x.
@creationix If you have something already in progress or prefer not to have pulls hanging open for a long time, feel free to close this as unmerged: I can issue a ready-to-merge pull around August when the Duktape 2.x changes are done. I posted this pull because I need the DukLuv 2.x changes for Duktape unit testing (which verifies compilation of DukLuv as one commit test).