Open
Conversation
MichalW
reviewed
Oct 5, 2017
package.json
Outdated
| "repository": { | ||
| "type": "git", | ||
| "url": "git://github.com/criso/fbgraph.git" | ||
| "url": "git://github.com/mgara/fbgraph.git" |
Contributor
There was a problem hiding this comment.
I think you should leave it as it was
Author
There was a problem hiding this comment.
sure ... that's why I explicitly mentioned the commit : bde6d29
And this commit is originated from my fork... but thanks for the comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My changes are related to multipart requests (required for uploading images)
check commit : bde6d29
The idea is to call the graph.multipart ...
I'm using this in a production system. try to rewrite or review the whole thing and integrate it to the main branch (criso/fbgraph)
Btw :
I had to synthesize my data before passing them to the formData body as below :
Basically you have to convert all the "boolean" variables in the post data to a "String" else it will throw an error.