Conversation
- rename fileName variable to headerComment (it holds a comment, not a filename) - remove unnecessary filepath.FromSlash conversion (use forward slashes consistently since this is a Unix filter tool) - use t.TempDir() in tests instead of manual setup/teardown - clarify README terminology: "block markers" with "block name" instead of "magic comments" These changes reduce complexity and better align with Go idioms for a ~370 line single-file CLI tool. Co-Authored-By: Warp <agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a filename)
consistently since this is a Unix filter tool)
instead of "magic comments"
These changes reduce complexity and better align with Go idioms for
a ~370 line single-file CLI tool.
Co-Authored-By: Warp agent@warp.dev