Skip to content

Conversation

@germiBest
Copy link

Problem: When setting a Field's datatype to a complex/composite datatype (e.g., ED, RP, CE), the serialization incorrectly produced empty output instead of the expected HL7 formatted string.

Example of the bug from #144:

from hl7apy.core import Message

m = Message()
m.obx.obx_5.datatype = 'ED'
m.obx.obx_5.ed_1 = ''
m.obx.obx_5.ed_2 = 'IM'
m.obx.obx_5.ed_3 = 'JPEG'
m.obx.obx_5.ed_4 = 'Base64'
m.obx.obx_5.ed_5 = 'SomeData'

# Before fix: Produces "OBX|||||" (missing data)
# After fix:  Produces "OBX|||||^IM^JPEG^Base64^SomeData" (correct)

Root cause: According to the https://hl7-definition.caristix.com/v2/HL7v2.5/DataTypes/ED, this is explicitly a composite datatype containing multiple components.

When a Field's datatype is changed to a composite datatype, the code must update the field's content type from 'leaf' to 'sequence' to indicate it has a composite structure with multiple child components. This content type is used by ElementFinder._parse_structure() to determine whether to build the necessary ordered_children and
structure_by_name dictionaries

Bug was that the SupportComplexDataType._set_datatype() method was updating the children reference and datatype, but forgot to update the content type from 'leaf' to 'sequence'. This caused the serialization logic to skip building the structure dictionaries, resulting in empty output.

Fix is actually a one-line change – setting content type to 'sequence' for composite datatypes

This aligns with the existing CanBeVaries implementation (used by Components) which already sets 'sequence' for composite datatypes at initialization.

Also added single unit test to verify serialization works correctly.

@germiBest
Copy link
Author

@svituz Hi, happy holidays! Is there a way to review and merge this? Tiny fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant