Skip to content

fix(debank): Flip sign of negative balances #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanjano merged 1 commit into from
Feb 3, 2025
Merged

fix(debank): Flip sign of negative balances #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion blockapi/test/v2/api/debank/data/bio_pools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@
},
"asset_token_list":[
{
"amount":988622.9649515124,
"amount":-988622.9649515124,
"chain":"eth",
"claimable_amount":4902.29790749049,
"decimals":18,
Expand Down
4 changes: 4 additions & 0 deletions blockapi/test/v2/api/debank/test_debank_portfolio_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,3 +163,7 @@ def test_parse_pools(debank_api, bio_polls):
assert parsed
for data_item in parsed.data:
assert data_item.items

for data_item in parsed.data:
for item in data_item.items:
assert item.balance > Decimal('0')
4 changes: 4 additions & 0 deletions blockapi/v2/api/debank.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,10 @@ def parse_item(
asset_type = AssetType.DEBT
amount = -amount

if amount < 0:
logger.info(f'Fixing negative item asset_type={asset_type}')
amount = -amount

if raw_amount == 0 and amount != 0:
raw_amount = decimals_to_raw(amount, coin.decimals)

Expand Down