fix(unisat): Fetch collection by collection name (slug) #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galvanizze
reviewed
Apr 15, 2025
blockapi/v2/api/nft/unisat.py
Outdated
Comment on lines
236
to
239
| volume=str(stats.get("btcValue", 0)), | ||
| sales_count=str(stats.get("listed", 0)), | ||
| owners_count=str(stats.get("total", 0)), | ||
| market_cap=str(stats.get("btcValue", 0)), |
Member
There was a problem hiding this comment.
q: do we process values in BTC? maybe USD would be better, but depends what we do with those data
Contributor
Author
There was a problem hiding this comment.
fixed, with market cap being computed as floor_price * total_nfts and btcValue = volume
galvanizze
approved these changes
Apr 15, 2025
SimSef
force-pushed
the
2149-blockapi-btc-nft-api-replacement-after-simplehash-shutdown
branch
from
512b163 to
6c0b63a
Compare
…r-simplehash-shutdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n method