Skip to content

fix(unisat): nft_type has default value if not provided #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimSef merged 1 commit into from
Apr 24, 2025
Merged

fix(unisat): nft_type has default value if not provided #230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions blockapi/v2/api/nft/unisat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ def parse_collection(self, fetch_result: FetchResult) -> ParseResult:

def fetch_listings(
self,
nft_type: BtcNftType,
nft_type: BtcNftType = BtcNftType.COLLECTION,
collection: Optional[str] = None,
cursor: Optional[str] = None,
limit: int = 100,
Expand Down Expand Up @@ -314,9 +314,6 @@ def fetch_listings(
Returns:
FetchResult containing listing data
"""
if not nft_type:
raise ValueError("NFT type is required")

# Ensure we get the string value if an enum is passed
nft_type_str = (
nft_type.value if isinstance(nft_type, BtcNftType) else str(nft_type)
Expand Down Expand Up @@ -453,7 +450,7 @@ def _yield_parsed_listings(

def fetch_offers(
self,
nft_type: Optional[BtcNftType] = None,
nft_type: BtcNftType = BtcNftType.COLLECTION,
address: Optional[str] = None,
inscription_id: Optional[str] = None,
event: Optional[str] = None,
Expand Down Expand Up @@ -482,7 +479,7 @@ def fetch_offers(
"""
# Ensure we get the string value if an enum is passed
nft_type_str = (
nft_type.value if isinstance(nft_type, BtcNftType) and nft_type else None
nft_type.value if isinstance(nft_type, BtcNftType) else str(nft_type)
)

start = int(cursor) if cursor else 0
Expand Down