-
Notifications
You must be signed in to change notification settings - Fork 11
fix: unisat collection fetch adjustment #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SimSef
merged 15 commits into
master
from
2149-blockapi-btc-nft-api-replacement-after-simplehash-shutdown
May 27, 2025
Merged
fix: unisat collection fetch adjustment #232
SimSef
merged 15 commits into
master
from
2149-blockapi-btc-nft-api-replacement-after-simplehash-shutdown
May 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r error on unisat side
…r-simplehash-shutdown
…r error on unisat side
…al server error on unisat side" This reverts commit 1391c09.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
A concise fix to adjust the UniSat collection fetch and NFT parsing logic.
- Added extraction of the address from fetch results (including a fallback mechanism) and built a collection_map using a new API endpoint.
- Updated NFT parsing to incorporate collection mapping and adjusted error handling.
- Modified test file by removing specific NFT parsing tests, potentially impacting test coverage.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| blockapi/v2/api/nft/unisat.py | Introduced new collection mapping logic and updated NFT parsing. |
| blockapi/test/v2/api/nft/test_unisat.py | Removed tests for NFT parsing which might reduce test coverage. |
Comments suppressed due to low confidence (1)
blockapi/test/v2/api/nft/test_unisat.py:24
- Removal of NFT parsing tests reduces test coverage for the new logic in parse_nfts. Consider adding tests that cover the new collection mapping and address extraction scenarios.
def test_parse_nfts(...):
ladovina
reviewed
May 27, 2025
ladovina
reviewed
May 27, 2025
ladovina
reviewed
May 27, 2025
ladovina
reviewed
May 27, 2025
ladovina
reviewed
May 27, 2025
ladovina
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.