Skip to content

Conversation

@SimSef
Copy link
Contributor

@SimSef SimSef commented May 27, 2025

No description provided.

@SimSef SimSef changed the title 2149 blockapi btc nft api replacement after simplehash shutdown feat: blockapi BTC NFT API replacement after simplehash shutdown May 27, 2025
@SimSef SimSef changed the title feat: blockapi BTC NFT API replacement after simplehash shutdown fix: unisat collection fetch adjustment May 27, 2025
@SimSef SimSef assigned ladovina and SimSef and unassigned ladovina May 27, 2025
@SimSef SimSef requested review from Copilot and ladovina May 27, 2025 11:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A concise fix to adjust the UniSat collection fetch and NFT parsing logic.

  • Added extraction of the address from fetch results (including a fallback mechanism) and built a collection_map using a new API endpoint.
  • Updated NFT parsing to incorporate collection mapping and adjusted error handling.
  • Modified test file by removing specific NFT parsing tests, potentially impacting test coverage.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
blockapi/v2/api/nft/unisat.py Introduced new collection mapping logic and updated NFT parsing.
blockapi/test/v2/api/nft/test_unisat.py Removed tests for NFT parsing which might reduce test coverage.
Comments suppressed due to low confidence (1)

blockapi/test/v2/api/nft/test_unisat.py:24

  • Removal of NFT parsing tests reduces test coverage for the new logic in parse_nfts. Consider adding tests that cover the new collection mapping and address extraction scenarios.
def test_parse_nfts(...):

@SimSef SimSef merged commit d704da8 into master May 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants