emit d.cts files in src/cjs#56
Conversation
|
Await review by @arijoon |
junderw
left a comment
There was a problem hiding this comment.
LGTM...
No clue how to test these weird packaging/transpiling issues.
We would need to have some CI that uses combinations of nodeJS versions, TS versions, webpack versions, etc etc etc and make sure all the combinations work...
It seems like newer versions of NodeJS have some new package.json keys that help with hybrid packages, but we don't want to bump the minimum NodeJS version too high.
arijoon
left a comment
There was a problem hiding this comment.
Thanks a lot, much appreciated. Tested against this repo by building this and packing locally, then installing it and works perfectly well
This lead me to find the issue also doesn't exist if typescript flag importHelpers is set to false. But we had this as true which manifests this issue. Worth noting importHelpers requires addition of tslib on the consumer side
|
Thanks for the |
package.jsontsconfig.base.jsonemits type declarations