Fix build error on x86_64 with non-binary shell #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build fails on x86_64 with a non-binary shell (such as the excellent xonsh Python-based shell) because `$SHELL` wouldn't give information about the userspace architecture (instead, I get `/usr/bin/xonsh: Python script, UTF-8 Unicode text executable`). I propose to simply check `/bin/sh` instead which is fairly guaranteed to be a binary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build fails on x86_64 with a non-binary shell (such as the excellent xonsh Python-based shell) because
$SHELLwouldn't give information about the userspace architecture (instead, I get/usr/bin/xonsh: Python script, UTF-8 Unicode text executable). I propose to simply check/bin/shinstead which is fairly guaranteed to be a binary.