Skip to content

Remove redundant log when GRPC exceptions occur #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glpatcern merged 1 commit into from
Dec 16, 2025
Merged

Remove redundant log when GRPC exceptions occur #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions cs3client/file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,21 +77,11 @@ def handle_grpc_error(func):
def wrapper(self, *args, **kwargs):
try:
return func(self, *args, **kwargs)

# Transport / gRPC-layer failures (no CS3 rpc.Status came back)
except grpc.RpcError as e:
# Log gRPC-layer info
self._log.error(
f"gRPC-layer error in {func.__name__}: code={getattr(e,'code',lambda:None)()} "
f"details={getattr(e,'details',lambda:None)()}"
)
status = _grpc_exc_to_cs3_status(e)
# Reuse existing mapping
self._status_code_handler.handle_errors(status, operation=func.__name__)
raise # fallback: should not be reached if handle_errors always raises
except Exception as e:
self._log.error(f"Client error in {func.__name__}: {e}")
raise

return wrapper

Expand Down
Loading