Review #73
Review #73
Conversation
xster
left a comment
xster
left a comment
There was a problem hiding this comment.
Sorry, gtg for the day. Only read the readme so far
|
|
||
| - multi-turn chat (remembering context along the way) | ||
| - streaming responses | ||
| - multi-line chat text input (via Alt/Opt+Enter on web/desktop) |
There was a problem hiding this comment.
ultra-nit: shift-enter seems like a more widespread convention except in excel/sheets. WDYT?
| - streaming responses | ||
| - multi-line chat text input (via Alt/Opt+Enter on web/desktop) | ||
| - cancel in-progress request | ||
| - edit the last prompt (starting with long-press as the UI gesture) |
| - multi-media attachments ([the web currently doesn't like file attachments](https://github.com/csells/flutter_ai_toolkit/issues/18), so they're disabled) | ||
| - handling structured LLM responses | ||
| - app-provided prompt suggestions | ||
| - pre-processing prompts to add prompt engineering, etc. |
There was a problem hiding this comment.
I didn't read the code yet. But maybe you're saying the API accepts programmatic system prompts right? "prompt engineering is too vague"
| - handling structured LLM responses | ||
| - app-provided prompt suggestions | ||
| - pre-processing prompts to add prompt engineering, etc. | ||
| - pre-processing requests to enrich the output, e.g. host Flutter widgets |
There was a problem hiding this comment.
Didn't read the code, but didn't understand what this means
| 1. model string, which you can ready about in [the Gemini models docs](https://ai.google.dev/gemini-api/docs/models/gemini), and | ||
| 1. an API key, which you can get [in Gemini AI Studio](https://aistudio.google.com/app/apikey). | ||
|
|
||
| With this in place, you're ready to write the Gemini code shown above. If you like, you can plug your API key and model string into the <a href="https://github.com/csells/flutter_ai_toolkit/blob/main/example/lib/gemini/gemini.dart">gemini.dart</a> sample. This sample has been tested on Android, iOS, the web and macOS, so give it a whirl. |
There was a problem hiding this comment.
seems like you want people to make a lib/gemini_api_key.dart file, but you didn't say so here. Maybe just ask users to input the key in the app and save to shared_preferences instead of not compiling?
| body: LlmChatView( | ||
| provider: GeminiProvider( | ||
| model: 'gemini-1.5-flash', | ||
| apiKey: googleApiKey, |
There was a problem hiding this comment.
apiKey: // Paste your own API key here
|
this is a super clever way to provide feedback. thank you @xster ! |
2 participants
Not a real PR. This is just the only way I can think of of being able to comment on every file