Fix CRAN-blocking issues for package submission#20
Merged
Conversation
This commit addresses critical issues that would prevent CRAN acceptance: 1. Remove .onLoad auto-install (CRAN policy violation) - Removed automatic package installation from R/zzz.R - Dependencies should only be declared in DESCRIPTION file 2. Fix Makevars.linux portability - Removed -march=native flag that causes binary incompatibility - Binaries will now work across different CPU architectures 3. Fix thread safety issues in C++ code - Converted static bool to std::atomic<bool> in deviance_gene.cpp - Converted static bool to std::atomic<bool> in calcDeviances.cpp - Used compare_exchange_strong for thread-safe one-time printing 4. Clean up code quality issues - Fixed typos in R/feature_selection.R comments - Removed unreachable code after return statement - Fixed typo "Requirments" -> "Requirements" in README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses critical issues that would prevent CRAN acceptance:
Remove .onLoad auto-install (CRAN policy violation)
Fix Makevars.linux portability
Fix thread safety issues in C++ code
Clean up code quality issues