Fix "Huidige groepen" button

[lodewiges]

Summary

Shortly summarize the changes in this pull request. Does it concern changes in the UI, add some screenshots. Are there related issues solved? Please, mention them (with 'fixes #xyz', see https://github.com/blog/1506-closing-issues-via-pull-requests), so they can be resolved automatically when merging this pull request.

Other information

If there is some other relavent and imporant information for this pull request, mention it here. For example, related pull requests (also in amber-api) or newly introduced conventions, packages or other dependencies.

Summary by CodeRabbit

• Refactor
  • Updated membership tab event handling for the groups and user views to a modern action-based binding. This is an internal improvement with no visible change to the UI or user workflows.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Replaced Ember template event bindings in two templates: switched anchor click handlers from the on 'click' syntax to the {{action '...'}} helper for selectCurrentMemberships and selectOldMemberships. No other markup or public API changes.

Changes

Cohort / File(s)	Summary
Template action helper updates app/templates/users/user/groups.hbs, app/templates/groups/group/index.hbs	Replaced on 'click' selectCurrentMemberships and on 'click' selectOldMemberships bindings with {{action 'selectCurrentMemberships'}} and {{action 'selectOldMemberships'}} respectively in two anchor elements. No other changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• fix 2fa button #1035 — Similar template-level change replacing {{on 'click' ...}} with the {{action '...'}} helper in other templates.

Suggested reviewers

• ToMaarton

Poem

🐰 I hopped through templates, light and spry,
Clicks now follow an action's cry,
Two anchors reborn, in cleaner array,
Hopping on handlers the Ember way 🥕✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is entirely empty placeholder template text with no actual summary of changes, no screenshots, no issue references, and no explanation of what was fixed or why.	Replace placeholder text with actual summary of changes—explain the event binding fix, specify affected components, and reference related issue(s) using 'fixes #xyz' format.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Fix "Huidge groepen" button' directly addresses the main change—fixing event binding for the 'Huidge groepen' (Current groups) button by switching from legacy on 'click' syntax to Ember's action helper, which matches the actual code modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR fixes the "Huidige groepen" (Current groups) and "Voorheen" (Previously) navigation buttons by adding the required this. prefix to action handler references in the Ember.js template. Without the this. prefix, these action handlers were not properly bound to the controller methods, causing the buttons to be non-functional.

Changes:

• Added this. prefix to selectCurrentMemberships action handler
• Added this. prefix to selectOldMemberships action handler

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 13.02%. Comparing base (c74ad13) to head (9c01cae).

Additional details and impacted files

@@           Coverage Diff            @@
##           staging    #1068   +/-   ##
========================================
  Coverage    13.02%   13.02%           
========================================
  Files          450      450           
  Lines         3124     3124           
========================================
  Hits           407      407           
  Misses        2717     2717           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.