Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new tool OverwriteIsValidFlag to facilitate comparing predictions from different experiments with the same effective area by allowing users to copy is_valid flags from one HDF5 file to another. This is particularly useful for making resolution curves more comparable between telescope designs like current LSTCam and AdvCam.
Key changes include:
- Addition of a new script
overwrite_isvalid_flag.pythat implements the tool for overwritingis_validflags - Standardization of command-line aliases to use hyphens instead of underscores in
append_subarray_table.py - Bug fix for incorrect flag description in
predict_model.py
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| scripts/overwrite_isvalid_flag.py | New tool for overwriting is_valid flags between HDF5 files with configurable reconstruction tasks and telescope filtering |
| scripts/overwrite_table.py | Added module docstring for clarity |
| scripts/append_subarray_table.py | Standardized command-line aliases to use hyphens instead of underscores |
| ctlearn/tools/predict_model.py | Fixed incorrect flag description for dl2-subarray (changed "telescope-event-wise" to "subarray-event-wise") |
Comments suppressed due to low confidence (1)
scripts/overwrite_isvalid_flag.py:6
- Import of 'np' is not used.
import numpy as np
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a tool to overwrite (or better write a new file) with the predictions from one experiment and the is_valid flag from another one. Helpful if you want to make event comparison and compare to telescope designs with the same eff area. E.g. to make resolution curves more comparable between current LSTCam and AdvCam.