Upgrade python and tensorflow and add unittests for main tools#269
Merged
TjarkMiener merged 27 commits intomainfrom Jan 26, 2026
Merged
Upgrade python and tensorflow and add unittests for main tools#269TjarkMiener merged 27 commits intomainfrom
TjarkMiener merged 27 commits intomainfrom
Conversation
…upload on github.event release
TjarkMiener
force-pushed
the
upgrade_python
branch
from
318c823 to
b2a5f6b
Compare
also added tests for mono predict tool remove flag to use_HDF5_merger component and use it by default overall clean up and code improvement
uses distinct CTLearn model prefixes for each reco tasks also train a LST models in conftest polish tests to test different image mappers and check for subarray and telescope tableloader reading
TjarkMiener
changed the title
rcervinoucm
approved these changes
Jan 22, 2026
Collaborator
rcervinoucm
left a comment
rcervinoucm
left a comment
There was a problem hiding this comment.
Everything looks clean to me, thanks a lot for the changes Tjark
BastienLacave
approved these changes
Jan 26, 2026
Collaborator
BastienLacave
left a comment
BastienLacave
left a comment
There was a problem hiding this comment.
Tested training at CSCS with docker file for energy and cameradirection on GPU.
Member
Author
|
@nietootein can you please review this PR? I'd like to avoid to populate this PR even further so it becomes more difficult to review. Before releasing a new version bumping the backend to keras3 and TF >= v2.16 we can add smaller dedicated PRs. Thanks in advance! |
nietootein
approved these changes
Jan 26, 2026
Member
nietootein
left a comment
nietootein
left a comment
There was a problem hiding this comment.
Thanks so much for this PR, @TjarkMiener ! Unittests and the upgrades were badly needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires dl1dh-#176; CI passed with dl1dh-v0.14.8.
Closes #38