Depends on #108: Add custom Gettext backend#114
Open
arturz wants to merge 41 commits into107-remove-dependency-on-specific-gettext-versionfrom
Open
Depends on #108: Add custom Gettext backend#114arturz wants to merge 41 commits into107-remove-dependency-on-specific-gettext-versionfrom
arturz wants to merge 41 commits into107-remove-dependency-on-specific-gettext-versionfrom
Conversation
- Rewrite the functional component - Add guards (nonnegative page number and total pages) - Add "surrounding_pages_number" to set number of the pages to the right and left visible in the UI. - Always show current page
When hit http://localhost:4000/kanta/ - proper redirect to the Dashboard
…rcentage Change translation progress calculation to use floor
Fix Pagination UI
Fix redirect to Dashboard
- Add Gettext.Backend implementation (Gettext 0.26.2) for Kanta. - Kanta Cached DB - Add Fallback Gettext backend for PO file checks - Gettext.Recompiler util module to support one time recompilation after mix gettext.extract Tests: - Add migration(v4) for test repo - Re-implemented DataCase helper (manual checkout) - Add tests for the Backend and Adapter
arturz
commented
Mar 28, 2025
- Remove Logger.debug(...) - add removing trailing "." to safe_folder_name (for Windows)
jk-lamb
force-pushed
the
108-base-on-gettext-026
branch
from
3d7dcbd to
6e86ced
Compare
…atibility Phoenix 1.8 compatibility [#122]
- Fix Dialyzer errors related to Phoenix version detection - Replace Mix.Dep.Lock.read/0 with Application.spec/2 for better static analysis compatibility - Add .dialyzer_ignore.exs to handle Phoenix dependency warnings - Update README to reflect Phoenix 1.7.x and 1.8.x compatibility
The changes add missing @moduledoc attributes to various modules, providing clear documentation about their purpose.
mix ecto.drop && mix ecto.create && mix ecto.migrate
- Add breaking change notice to CHANGELOG.md explaining Gettext 0.26.0 migration requirements
- Fix apply_bindings return type from :not_found to {:error, :not_found} to match codebase conventions
- Rename KantaCachedDB to CachedDB module (remove redundant Kanta prefix)
- Update all references to use new module name
- Add breaking change notice to CHANGELOG.md explaining Gettext 0.26.0
migration requirements - Fix apply_bindings return type from :not_found
to {:error, :not_found} to match codebase conventions - Rename
KantaCachedDB to CachedDB module (remove redundant Kanta prefix) -
Update all references to use new module name
Relocates GettextRecompiler flag files from priv/kanta/ to environment-specific build directories using Mix.Project.build_path(). This prevents confusion about whether temporary build artifacts should be committed to version control, as _build/ is already in .gitignore.
The flag files now reside in:
- _build/{env}/kanta_recompile/.gettext_recompiled
- _build/{env}/kanta_recompile/.fallback_recompiled
…-dev/kanta into 108-base-on-gettext-026 # Conflicts: # lib/kanta/backend.ex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.