Skip to content

124 bug kanta logo image is missing#132

Merged
vincentvanbush merged 2 commits intodevelopfrom
124-bug-kanta-logo-image-is-missing
Oct 24, 2025
Merged

124 bug kanta logo image is missing#132
vincentvanbush merged 2 commits intodevelopfrom
124-bug-kanta-logo-image-is-missing

Conversation

@jk-lamb
Copy link
Contributor

@jk-lamb jk-lamb commented Oct 21, 2025

Pull Request

Description

This PR fixes the missing Kanta logo image in the dashboard footer by replacing it with the Curiosum logo and adding a clickable link to the Curiosum website. The footer content has also been centered for better visual alignment.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring
  • Test improvements
  • CI/CD improvements

Related Issues

Fixes #124

Changes Made

  • Replaced missing Kanta logo with Curiosum logo in dashboard footer
  • Added clickable link to Curiosum website (https://www.curiosum.com/)
  • Centered the "Made with ❤️" footer content
  • Updated logo image source to use Curiosum CDN
  • Cleaned up footer styling for better visual presentation

Testing

Test Environment

  • Elixir version:
  • OTP version:
  • Phoenix version:
  • Database:
  • Gettext version:

Test Cases

  • All existing tests pass
  • Manual testing performed (verified logo displays correctly and link works)

Test Commands Run

# Visual inspection of dashboard footer
# Verified logo loads correctly
# Verified link navigates to Curiosum website
# Tested in both light and dark modes

Documentation

  • Updated README.md (if applicable)
  • Updated documentation comments (with examples for new features)
  • Updated CHANGELOG.md (if applicable)

Code Quality

  • Code follows the existing style conventions
  • Self-review of the code has been performed
  • Code has been commented, particularly in hard-to-understand areas
  • No new linting warnings introduced
  • No new Dialyzer warnings introduced

Backward Compatibility

  • This change is backward compatible
  • This change includes breaking changes (please describe below)
  • Migration guide provided for breaking changes

Breaking Changes

N/A

Performance Impact

  • No performance impact
  • Performance improvement
  • Potential performance regression (please describe)

Performance Notes

No performance impact - only UI changes to dashboard template.

Translation Management Impact

  • No impact on existing translations
  • Affects translation extraction process
  • Affects translation storage/retrieval
  • Affects Kanta UI/dashboard
  • Affects plugin system
  • Database schema changes

Translation Impact Notes

This change only affects the visual presentation of the dashboard footer, not translation functionality.

Security Considerations

  • No security impact
  • Security improvement
  • Potential security impact (please describe)

Additional Notes

The Curiosum logo is loaded from their official CDN and includes proper alt text for accessibility. The logo adapts to dark mode using the dark:bg-transparent class.

Screenshots/Examples

Before: Missing/broken logo image in footer

After:

  • Curiosum logo displayed correctly in footer
  • Logo is clickable and links to https://www.curiosum.com/
  • Footer content is centered
  • Logo adapts properly to light/dark mode
image image

Checklist

  • I have read the Contributing Guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Reviewer Notes

Please verify that:

  1. The Curiosum logo displays correctly in both light and dark modes
  2. The link to the Curiosum website opens correctly
  3. The footer content appears centered in the sidebar

@jk-lamb jk-lamb force-pushed the 124-bug-kanta-logo-image-is-missing branch from 4c04e65 to d2d73f9 Compare October 23, 2025 19:09
@jk-lamb jk-lamb self-assigned this Oct 23, 2025
@jk-lamb jk-lamb force-pushed the 124-bug-kanta-logo-image-is-missing branch from 05b3714 to 560eca9 Compare October 23, 2025 20:05
@vincentvanbush vincentvanbush force-pushed the 124-bug-kanta-logo-image-is-missing branch from 560eca9 to bb847b9 Compare October 24, 2025 10:25
@vincentvanbush vincentvanbush merged commit 2fcc38b into develop Oct 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants