feat: loan management form add/remove collateral #1715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0xPearce
commented
Nov 28, 2025
apps/main/src/llamalend/features/manage-loan/components/AddCollateralForm.tsx
Outdated
Show resolved
Hide resolved
apps/main/src/llamalend/widgets/manage-loan/LoanInfoAccordion.tsx
Outdated
Show resolved
Hide resolved
apps/main/src/llamalend/widgets/manage-loan/LoanFormTokenInput.tsx
Outdated
Show resolved
Hide resolved
apps/main/src/llamalend/widgets/manage-loan/LoanInfoAccordion.tsx
Outdated
Show resolved
Hide resolved
apps/main/src/llamalend/features/manage-loan/components/AddCollateralForm.tsx
Outdated
Show resolved
Hide resolved
0xPearce
changed the title
0xAlunara
previously approved these changes
Dec 16, 2025
DanielSchiavini
previously approved these changes
Dec 17, 2025
Collaborator
DanielSchiavini
left a comment
DanielSchiavini
left a comment
There was a problem hiding this comment.
LGTM comments are nitpicking
| value: decimal(new BigNumber(values.userCollateral).plus(state.collateral)) as Decimal, | ||
| tokenSymbol: collateralToken?.symbol, | ||
| }) ?? | ||
| null, |
Collaborator
There was a problem hiding this comment.
undefined should be OK too right?
Collaborator
Author
There was a problem hiding this comment.
Shit I forgot to remove it, it's completely useless
| state.collateral && | ||
| values.userCollateral && { | ||
| value: decimal( | ||
| BigNumber.max('0', new BigNumber(state.collateral).minus(new BigNumber(values.userCollateral))), |
Collaborator
There was a problem hiding this comment.
Suggested change
| BigNumber.max('0', new BigNumber(state.collateral).minus(new BigNumber(values.userCollateral))), | |
| BigNumber.max(0, new BigNumber(state.collateral).minus(new BigNumber(values.userCollateral))), |
Collaborator
There was a problem hiding this comment.
btw I also found the clamp function which could be adapted to Decimal clamps
…d-collateral-form
DanielSchiavini
dismissed stale reviews from 0xAlunara and themself
via
55f70b9
DanielSchiavini
previously approved these changes
Dec 17, 2025
0xAlunara
previously approved these changes
Dec 17, 2025
…d-collateral-form
DanielSchiavini
dismissed stale reviews from 0xAlunara and themself
via
1767430
DanielSchiavini
approved these changes
Dec 17, 2025
0xAlunara
approved these changes
Dec 17, 2025
michwill
approved these changes
Dec 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collateral,prevCollateral,prevHealth,prevDebtandprevLTVto the accordiongetErrorMessagefrom/loanand/lendint/llamalendGracefully handle user rejection (unlike my Ex):