Skip to content

Conversation

@0xPearce
Copy link
Collaborator

@0xPearce 0xPearce commented Dec 16, 2025

Late small pull request to remove the phishing banner from previews only, and only show it on production and development.

@vercel
Copy link

vercel bot commented Dec 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
curve-dapp Ready Ready Preview, Comment Dec 17, 2025 10:49am
curve-dapp-storybook Ready Ready Preview, Comment Dec 17, 2025 10:49am

0xAlunara
0xAlunara previously approved these changes Dec 16, 2025
Copy link
Collaborator

@0xAlunara 0xAlunara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol somebody got annoyed by the fact that local storage differs per PR url 🤣

Copy link
Collaborator

@DanielSchiavini DanielSchiavini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have tests ser

@0xPearce
Copy link
Collaborator Author

EDIT: phishing banner hidden only in previews, but still shown in development and production.
IMO better like this because tests can still run and I wanted to avoid dissmissing the banner on every Previews. For production and development we have to dismiss it once per month, which is fine

@0xPearce 0xPearce marked this pull request as draft December 17, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants