-
Notifications
You must be signed in to change notification settings - Fork 45
feat: global banner for Aave v2 deprecation on Polygon and Avalanche #1792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0xAlunara
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eh, it works for now, but this is kinda blinding 😎
I think @0xtutti needs to look at stacking banners at some point, this looks undercooked
| {t`There is an issue connecting to the API. Please try to switch your RPC in your wallet settings.`} | ||
| </Banner> | ||
| )} | ||
| {showAaveBanner && currentApp === 'dex' && (chainId === Chain.Polygon || chainId === Chain.Avalanche) && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avalanche and Polygon are just for dex right?
| {showAaveBanner && currentApp === 'dex' && (chainId === Chain.Polygon || chainId === Chain.Avalanche) && ( | |
| {showAaveBanner && [Chain.Polygon, Chain.Avalanche].includes(chainId) && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but
- what if we add one of those chains on llamalend?
- it is technically possible to stay Avalanche/Polygon chains on llamalend, if selected on the dex previously
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, the llamalend app accepts any network!
347a7c3
AAVE v2 froze all assets and swaps / deposits are disabled on Polygon and Avalanche networks.
Since almost all Curve pools on Polygon and Avalanche networks utilize AAVE v2, added a global banner for these networks for the Dex app only.
Also refactored the
DAY_IN_MSconstant because reused many times and created aDuration.BannerUsing the Banner is becoming easy and beautiful 😄