refactor: remove unnecessary updating of token balances on quickswap #1801
+8
−36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR reasons about the existing store + fetching infrastructure. In the future, we will replace it with hooks + queries, but for now:
The dex global slice calls
await state.pools.fetchPools(config, curveApi, poolIds, failedFetching24hOldVprice)during hydrationfetchPoolsfetches all pool user balances with the following snippet:Therefore, during hydration all tokens balances are being fetched already.
In addition, inside the
useAutoRefreshof the dex layout, we have:Therefore, all user balances already get periodically updated and hence we can remove:
from the quick swap page, which gets triggered each time you switch tabs in the browser.
In addition, user balances are also being fetched already when updating the quick swap form by
setFormValueswith:Which means the form will use the latest balances anyway