chore: add core location types, config, and EventBus event#654
Open
Shahroz16 wants to merge 2 commits intofeat/real-time-locationfrom
Open
chore: add core location types, config, and EventBus event#654Shahroz16 wants to merge 2 commits intofeat/real-time-locationfrom
Shahroz16 wants to merge 2 commits intofeat/real-time-locationfrom
Conversation
Add foundational location types and wiring needed by subsequent location features: - LocationModuleConfig: enableLocationTracking flag with Builder - LocationData / TrackLocationEvent in core Event sealed class - LocationSnapshot, AuthorizationStatus, LocationProviderError, LocationGranularity types in location module - LocationProviding interface abstracting platform location services - LocationRequestException for structured error propagation - DataPipeline subscription for TrackLocationEvent -> "Location Update" - LOCATION_UPDATE event name constant Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/real-time-location #654 +/- ##
==========================================================
Coverage ? 68.20%
Complexity ? 760
==========================================================
Files ? 142
Lines ? 4322
Branches ? 582
==========================================================
Hits ? 2948
Misses ? 1148
Partials ? 226 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Build available to test |
|
|
📏 SDK Binary Size Comparison Report
|
# Conflicts: # core/api/core.api
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LocationModuleConfigwithenableLocationTrackingflag and Builder patternAuthorizationStatus,LocationGranularity,LocationProviderError,LocationSnapshotLocationProviderinterface andLocationRequestExceptionfor provider abstractionTrackLocationEvent/LocationDatato the coreEventsealed class for inter-module communicationLOCATION_UPDATEevent name constantTrackLocationEventand track as "Location Update" with lat/lng propertiesThis PR lays the foundation for the location module by establishing the type system, configuration, and the EventBus contract between the location module and DataPipeline. No public location API is exposed yet.
Note
Medium Risk
Introduces a new cross-module event type and begins emitting location tracking events (including lat/lng), which can impact analytics data and privacy expectations if published inadvertently.
Overview
Adds a location foundation across modules:
LocationModuleConfignow supports anenableLocationTrackingflag (with builder + default module constructor), and the location module introduces internal provider abstractions and framework-agnostic location/authorization types.Extends the core
Eventbus contract withTrackLocationEvent+LocationData, addsEventNames.LOCATION_UPDATE, and wires DataPipelines to subscribe to location events and emit a"Location Update"track event withlat/lngproperties.Written by Cursor Bugbot for commit 7843bc0. This will update automatically on new commits. Configure here.