refactor!: Introduce Synchronized primitive and adapt classes to its use#974
Draft
hollyschilling-cio wants to merge 33 commits intomainfrom
Draft
refactor!: Introduce Synchronized primitive and adapt classes to its use#974hollyschilling-cio wants to merge 33 commits intomainfrom
hollyschilling-cio wants to merge 33 commits intomainfrom
Conversation
added 3 commits
December 23, 2025 15:50
…ration to replace TaskBag. - Rewrote EventBusObserversHolder to utilize Synchronized to protect its contents. - Updated EventBusHandlerTest to fix test that depended upon a memory leak that is now fixed.
…y and replaced them with uses of Synchronized.
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. |
hollyschilling-cio
changed the title
SDK binary size reports 📊SDK binary size of this PRSDK binary size diff report vs. main branch |
hollyschilling-cio
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #974 +/- ##
==========================================
+ Coverage 65.40% 66.46% +1.06%
==========================================
Files 172 171 -1
Lines 8024 8347 +323
==========================================
+ Hits 5248 5548 +300
- Misses 2776 2799 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
added 4 commits
December 26, 2025 11:34
Incidentally added a `isEmpty` method to Synchronized Collection extension because the linter required it and it was a good idea.
…Synchronized, AsyncOperation, and DictionaryProtocol.
…e in method name.
added 13 commits
December 26, 2025 21:44
…they were crashing during testing.
… common base model.
… migrating them to use SwiftTesting. Removed additional references to AutoLenses.
added 5 commits
December 30, 2025 15:08
… tests because it seems to cause problems with GitHub.
added 5 commits
December 30, 2025 17:30
| await asyncBlock() | ||
| finish() | ||
| } | ||
| } |
There was a problem hiding this comment.
AsyncOperation cancellation leaves operation in incomplete state
When AsyncOperation is cancelled after start() is called but before the Task body executes, the guard statement at line 59 returns early without calling finish(). Since start() already set isExecuting = true, the operation remains in an invalid state (isExecuting = true, isFinished = false) indefinitely. This can cause OperationQueue to hang waiting for operations that will never complete. The issue is particularly relevant in CioEventBusHandler.deinit which calls cancelAllOperations() on pending operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NSRecursiveLockComplete each step to get your pull request merged in. Learn more about the workflow this project uses.
Note
Modernizes concurrency and thread-safety across the SDK.
Synchronized<T>wrapper andAsyncOperationadded; many classes updated to useSynchronizedorNSRecursiveLock(e.g.,EventBusObserversHolder,CioEventBusHandler,QueueInventoryMemoryStoreImpl,ModuleTopLevelObject,CioSimpleTimer,PushHistoryImpl).QueueTask,QueueTaskMetadata, andQueueTaskRunResultsfields made mutable (var); removedAutoLensesusage and generated files; deletedArrayExtensions.mapNonNilin favor ofcompactMap.Synchronizedand usesOperationQueueasync ops; handler loads/replays/posts events via queued async operations.Lock,LockManager, andTaskBag; rewroteRingBufferwith clearer indices, count, and bulk enqueue.SynchronizedTests; updated event bus, atomic, ring buffer, and push history tests.macos-15; Fastlane simulator updated toiPhone 16; sample app Xcode project cleaned of lenses references.Written by Cursor Bugbot for commit f8e6f93. This will update automatically on new commits. Configure here.