feat: Update example app icons#549
Merged
hollyschilling-cio merged 5 commits intomainfrom Dec 4, 2025
Merged
Conversation
Contributor
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
This reverts commit 914bb3b.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| "idiom" : "universal", | ||
| "platform" : "ios", | ||
| "size" : "1024x1024" | ||
| } |
There was a problem hiding this comment.
Bug: Missing filenames for dark and tinted icon variants
The dark mode appearance (lines 9-19) and tinted appearance (lines 20-30) image entries are missing the filename property. Only the default icon has "filename" : "iOS React Native APN.png" specified. Without filenames, iOS won't be able to load the appropriate icons for dark mode and tinted appearances, causing these variants to fall back to the default or display no icon.
hollyschilling-cio
changed the title
clabland
approved these changes
Dec 4, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Dec 4, 2025
## [5.3.0](5.2.0...5.3.0) (2025-12-04) ### Features * Update example app icons ([#549](#549)) ([5e6f255](5e6f255))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the app icons in the example apps.
Also corrected minor linting errors.
Note
Updates example app icons across Android/iOS, tweaks Android launcher background color, and renames the Android app to "React Native FCM".
foregroundto@mipmap/ic_launcher_foregroundinexample/android/app/src/main/res/mipmap-anydpi-v26/ic_launcher.xmlandic_launcher_round.xml.ic_launcher_backgroundcolor to#18343Ainvalues/ic_launcher_background.xml.app_nametoReact Native FCMinvalues/strings.xml.example/ios/SampleApp/Assets.xcassets/AppIcon.appiconset/Contents.jsonwith universal1024x1024icon entries, including dark/tinted appearance variants.Written by Cursor Bugbot for commit 83791b4. This will update automatically on new commits. Configure here.