-
Notifications
You must be signed in to change notification settings - Fork 7
Code release #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code release #1
Conversation
|
To be added to tools: rotate_asl.py |
| self.keyframe_frame_ids: Optional[Dict[int, int]] = None | ||
|
|
||
| @staticmethod | ||
| def run( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add a demo or test for this function in the top level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The demo will be via the run_pipeline? It will run the entire pipeline thus testing each of the 4 modules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to expose this key framing module, we would have a demo or test on it. If we only have run_pipeline.py in the top level, it means that we do not expect user to know of any other interfaces, and this run_pipeline is the only feature that matters.
B1ueber2y
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some more comments with some refactorization suggestions.
B1ueber2y
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Left more comments according to the new changes.
This PR sets up the VI Optimization pipeline and also adds some general conversion tools. To run the pipeline
It is broken into 4 modules:
Parameters for these modules can be set in ./defaults.yaml. The various parameters are read and passed into PipelineOptions class (lamaria/config/pipeline.py). Module-based options are also set in lamaria/config/options.py.