Skip to content

Conversation

@nushakrishnan
Copy link
Collaborator

This PR sets up the VI Optimization pipeline and also adds some general conversion tools. To run the pipeline

python -m run_pipeline --vrs path_to_vrs --output path_to_output --estimate path_to_estimate

It is broken into 4 modules:

  • Conversion to COLMAP: converts the input estimate (or MPS folder) into an initial COLMAP model
  • Keyframing: performs keyframing based on input keyframing params on the intial COLMAP model
  • Triangulation: triangulation is run using hloc triangulation function on the keyframed COLMAP model
  • VI Optimization: runs visual inertial optimization on the triangulated COLMAP model

Parameters for these modules can be set in ./defaults.yaml. The various parameters are read and passed into PipelineOptions class (lamaria/config/pipeline.py). Module-based options are also set in lamaria/config/options.py.

@nushakrishnan
Copy link
Collaborator Author

To be added to tools: rotate_asl.py

self.keyframe_frame_ids: Optional[Dict[int, int]] = None

@staticmethod
def run(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add a demo or test for this function in the top level.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The demo will be via the run_pipeline? It will run the entire pipeline thus testing each of the 4 modules?

Copy link
Member

@B1ueber2y B1ueber2y Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to expose this key framing module, we would have a demo or test on it. If we only have run_pipeline.py in the top level, it means that we do not expect user to know of any other interfaces, and this run_pipeline is the only feature that matters.

Copy link
Member

@B1ueber2y B1ueber2y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some more comments with some refactorization suggestions.

Copy link
Member

@B1ueber2y B1ueber2y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Left more comments according to the new changes.

@B1ueber2y B1ueber2y merged commit a1109fd into main Sep 30, 2025
1 check passed
@B1ueber2y B1ueber2y deleted the dev branch September 30, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants