Keeping imu_from_rig constant at identity #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the optimize_imu_from_rig configuration option and ensures that IMU-to-rig transformation parameters are always kept constant during optimization. The change simplifies the optimization configuration by hardcoding this behavior instead of making it configurable.
- Removed
optimize_imu_from_rigboolean flag from configuration options - Updated optimization logic to always keep IMU-to-rig parameters constant
- Cleaned up legacy comment in defaults configuration
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lamaria/config/options.py | Removed optimize_imu_from_rig boolean field from OptIMUOptions class |
| lamaria/pipeline/optim/residual.py | Simplified optimization setup by removing conditional logic and always keeping IMU-to-rig parameters constant |
| defaults.yaml | Removed optimize_imu_from_rig configuration entry and legacy comment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
B1ueber2y
approved these changes
Oct 8, 2025
Collaborator
Author
|
Accidentally clicked on Copilot for review... is there a way to disable this option? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed a legacy comment.