Skip to content

Conversation

@puzzledpolymath
Copy link
Contributor

@puzzledpolymath puzzledpolymath commented Jul 10, 2025

🔍 What was changed

  • Updated composer psalm version to support PHP 8.4
  • Updated contributing instructions for running docker compose
  • Added further unit tests proving an issue with merging attributes when a default value is defined
  • Added a fix ensuring attributes are merged correctly
  • General house cleaning in order to get pipelines working correctly

📝 Checklist

While this PR does not close a particular ticket. The issue was raised here: cycle/database#228

  • How was this tested:
    • Unit tests added

@puzzledpolymath puzzledpolymath requested a review from roxblnfk July 10, 2025 01:54
@cycle cycle deleted a comment from codecov bot Jul 10, 2025
@cycle cycle deleted a comment from codecov bot Jul 10, 2025
@codecov
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.86%. Comparing base (af4816c) to head (47e3c88).
Report is 11 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x      #82      +/-   ##
============================================
- Coverage     94.86%   94.86%   -0.01%     
  Complexity      591      591              
============================================
  Files            45       45              
  Lines          1676     1675       -1     
============================================
- Hits           1590     1589       -1     
  Misses           86       86              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@puzzledpolymath
Copy link
Contributor Author

@roxblnfk Let me know if anything further is needed here. Ideally I'll like to see this merged and then move onto cycle/database#228, which I'll likely needed assistance with.

@roxblnfk roxblnfk merged commit c59071a into 2.x Jul 10, 2025
30 checks passed
@roxblnfk roxblnfk deleted the fix-attributes-not-merged branch July 10, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants