Refactor XYZ color space into its own module.#84
Conversation
|
This looks like a worthwhile refactoring and I’m in favor of exporting d3.xyz. 👍 |
|
@mbostock the PR is ready for review |
|
Per @danburzo’s comment #51 (comment), what do you think about the choice of illuminant (D65 vs. D50)? One possibility is that the XYZ class has a field which stores the illuminant ( Also, does this PR affect the performance of converting between Lab and RGB because it now makes explicit the extra chromatic adaptation step rather than combining it into the matrix multiplication? |
See my comment on #51
Is there a benchmark you use for this? How have you tested performance impact in the past? |
|
@mbostock friendly ping |
|
In a recent addition to the css-color-4 spec, @svgeesus has made the following adjustments as per w3c/csswg-drafts#6722:
These are all predefined color profiles for the
|
For #51
Refactors the implementation of the XYZ color space (i.e. CIE XYZ D50) out of
src/lab.jsinto its own module,src/xyz.js.