Allow users to inject custom interpolators#43
Open
mcnuttandrew wants to merge 1 commit intod3:mainfrom
Open
Conversation
Author
|
@mbostock bump for review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the concerns raised in #42 by following @mbostock's suggestions in the same thread. Specifically: it presents a new function, customInterpolate, that allows users to specify an object of functions that will override the default versions of those interpolators.
This can be useful if you want use the top level interpolator, but don't want to interpolate through RGB, or if you want to prune children from a tree you are interpolating against, or simply just don't want strings to be interpolated.