Skip to content

Conversation

@FH-Inway
Copy link
Member

@FH-Inway FH-Inway commented Sep 1, 2025

#871 inadvertently introduced a dependency on the 1.9.308 version of PSFramework by using the PSFDirectory parameter type.

d365collaborative#871 inadvertently introduced a dependency on the 1.9.308 version of PSFramework by using the PSFDirectory parameter type.
@FH-Inway FH-Inway requested a review from Splaxi September 1, 2025 14:41
@FH-Inway
Copy link
Member Author

FH-Inway commented Sep 1, 2025

@Splaxi Kind of interesting how I noticed this. Normally, this is not an issue, since Install-Module d365fo.tools will install the latest version of the dependencies. But recently, I have been looking into Install-PSResource d365fo.tools. As I understand it, Install-PSResource is the newer way of installing PowerShell modules and should be preferred over Install-Module. But in good old Microsoft fashion, the new stuff is not fully compatible with the old stuff.
Case in point, Install-PSResource installs the oldest possible version of the dependencies.

Anyway, do you mind updating the PSFramework dependency to 1.9.308? That version is from 2 years ago. Or I can refactor the changes in #871 to not make use of PSFDirectory.

@Splaxi
Copy link
Collaborator

Splaxi commented Sep 2, 2025

Let's update the dependency - I trust Fred and his work, as he is even more ridgid than me with breaking changes.

You can do it - if you feel for it.

@FH-Inway FH-Inway merged commit fb7d1b1 into d365collaborative:master Sep 2, 2025
5 checks passed
@FH-Inway FH-Inway deleted the fix-psframework-dependency-version branch September 2, 2025 14:37
@Splaxi
Copy link
Collaborator

Splaxi commented Sep 3, 2025

Reason for my focus on non-breaking changes....

image

@FH-Inway
Copy link
Member Author

FH-Inway commented Sep 4, 2025

Yeah, I was also suprised by the 150 downloads just 3 hours after the new version was released. Sometimes I wish we had some telemetry data for d365fo.tools to e.g. see how many installs are by automated pipelines.

@Splaxi
Copy link
Collaborator

Splaxi commented Sep 4, 2025

I would argue 99%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants