Improve code with warning of Visual code analysis

[leguims]

can fix issue #4

[daancode]

Hi ! Thanks for your PR. I'm not convinced about throwing an exception, maybe better solution is to clamp coords to world size or return empty vector if coords are invalid ?

[leguims]

Return empty vector is like "no way found". But user does not known that "inputs was bad". Exception is more explicit for me.
Clamp to world size is better, but user does not know that coords were bad as input data. Maybe, result with clamped coords could be wrong.

[daancode]

I see your point, but still I'd rather avoid using exceptions. What do you think about assertion and enum to indicate internal generator state ?

enum class State
{
    Ready,
    InvalidArguments,
    InternalError,
    Success
}

auto path = generator.findPath({0, 0}, {20, 20});
if(generator.getState() == AStar::State::Success)
{
    // Your path is valid.
}

[leguims]

Could you explain to me why do you want to avoid exceptions ?

Your solution works, if your prefer it, that's ok for me. But I still prefer exceptions, because you can forget to check "generator.getState()", but not exceptions. That's the advantage of exceptions, you cannot ignore them or you have to do it explicitly.

[leguims]

The commit "Improve code with warning of Visual code analysis - e7aaf02" use getState() instead of exception. You can take it. Probably the use of "success", "ready" and other states need more code.

Ignore the commit "Replace getState() error management by exception management - d977c96" (and later), because, this is the return of exception, which is good for me, cause I don't want to check getState() each time I use "find" method. This is what I prefer, but I understand that you avoid exception usage. 😃

[daancode]

Thank you :) Using the exception forces the way in which the application must deal with incorrect arguments. I think the better solution is to validate coordinates before passing it to the find method. Validation can be done in any way, and its depends on the programmer preferences.