fix: typo in s3Key #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a typo in the attribute name from "s3key" to "s3Key" across tests, documentation, and example code while also bumping the package version to 1.0.3.
- Updated spec files to reflect the correct attribute name.
- Adjusted documentation examples and schema definitions accordingly.
- Bumped package version and updated associated build files.
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| spec/models/list_recordings200_response_data_inner_spec.rb | Corrected attribute name in test description. |
| spec/models/get_transcript_info200_response_out_params_spec.rb | Corrected attribute name in test description. |
| spec/models/get_recording_info200_response_tracks_inner_spec.rb | Corrected attribute name in test description. |
| spec/models/get_recording_info200_response_spec.rb | Corrected attribute name in test description. |
| lib/daily-ruby/version.rb | Bumped version from 1.0.2 to 1.0.3. |
| example.rb | Updated example to include new recording options. |
| docs/ListRecordings200ResponseDataInner.md | Corrected attribute name in documentation. |
| docs/GetTranscriptInfo200ResponseOutParams.md | Corrected attribute name in documentation. |
| docs/GetRecordingInfo200ResponseTracksInner.md | Corrected attribute name, contains a typo in description. |
| docs/GetRecordingInfo200Response.md | Corrected attribute name in documentation. |
| daily-ruby.gemspec | Updated file listings and dependency handling, version bump. |
| README.md | Updated package version and installation instructions. |
| LICENSE.txt | Introduced new BSD 2-Clause License file. |
| .travis.yml | Updated gem installation version in CI configuration. |
Files not reviewed (1)
- run.sh: Language not supported
Add license Update example Remove batch example Update docs/GetRecordingInfo200ResponseTracksInner.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Fix gem spec Fix Gemfile.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a typo expecting recordings to return an
s3keyfield when, in reality, it returns ans3Keyfield. Daily.co official docs will also receive an update.