Conversation
franmc01
commented
Jan 15, 2026
- Add cursor engine support in package.json
- Update fast-xml-parser to v5 and migrate to XMLParser API
- Update simple-plist to v1.3.1
- Add skipLibCheck to tsconfig.json to handle type issues
- Update install:all script to include preview and starter dependencies
- Add cursor engine support in package.json - Update fast-xml-parser to v5 and migrate to XMLParser API - Update simple-plist to v1.3.1 - Add skipLibCheck to tsconfig.json to handle type issues - Update install:all script to include preview and starter dependencies
There was a problem hiding this comment.
Pull request overview
This PR adds support for the Cursor editor and updates several dependencies to resolve type compatibility issues. The main changes involve migrating from fast-xml-parser v3 to v5, updating simple-plist, and adding TypeScript compiler options to handle type checking issues.
Changes:
- Added Cursor editor support with engine version requirement
- Migrated fast-xml-parser from v3 to v5 with API changes (parse function → XMLParser class)
- Updated simple-plist from 1.3.0 to 1.3.1
- Added skipLibCheck to tsconfig.json to suppress type checking in library files
- Extended install:all script to include preview and starter dependencies
Reviewed changes
Copilot reviewed 5 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added cursor engine, updated fast-xml-parser to ^5.3.3, simple-plist to ^1.3.1, and extended install:all script |
| tsconfig.json | Added skipLibCheck: true to compiler options |
| src/xcode.ts | Changed plist import from namespace import to default import |
| src/native-project-ios.ts | Changed plist import from namespace import to default import |
| src/native-project-android.ts | Migrated from parse() function to XMLParser class constructor pattern |
| src/analyzer.ts | Migrated from parse() function to XMLParser class constructor pattern with updated option names |
| package-lock.json | Updated dependencies and peer dependencies to match package.json changes |
| starter/package-lock.json | Updated peer dependency flags for Angular and related packages |
| preview/package-lock.json | Updated peer dependency flags for Angular and related packages |
| plugin-explorer/package-lock.json | Updated peer dependency flags for Angular and related packages |
Files not reviewed (3)
- plugin-explorer/package-lock.json: Language not supported
- preview/package-lock.json: Language not supported
- starter/package-lock.json: Language not supported
- Extract XMLParser configuration into a separate function for better readability and maintainability. - Update the processConfigXML and processAndroidXML functions to utilize the new configuration function.
|
I ran a few tests around this - Cursor support is already available. Cursor reads the "vscode" section for engine support and allows you to debug and edit the extension. The extension is also deployed to https://open-vsx.org/ so it can be installed in Cursor / Windsurf etc. I also tested out the changes related to the xml parser and it looks like the code paths used by this need to be cleaned up. I'll do that in another PR. I appreciate the PR and the updates though and will merge. |
