Skip to content

Conversation

@rahulk29
Copy link
Contributor

@rahulk29 rahulk29 commented Feb 9, 2025

Adds support for VIA definitions as described in the LEF 5.8/6.0 specification:

  • "Fixed" vias (ie. those with an explicitly listed set of shapes)
  • "Generated" vias (ie. those described by a VIARULE)

Note that although we support parsing both kinds of vias, we don't yet support parsing VIARULE GENERATE statements (which generated vias reference).

@rahulk29 rahulk29 changed the title support reading/writing LEF fixed via definitions Support reading/writing LEF fixed via definitions Feb 9, 2025
@rahulk29 rahulk29 changed the title Support reading/writing LEF fixed via definitions Support reading/writing LEF via definitions Feb 10, 2025
@dan-fritchman
Copy link
Owner

Alright! Welcome back.
PR looks great.
A heads up there are a few others open for LEF parsing & writing - namely #53 #54 #56.
CC @nanobowers

@rahulk29
Copy link
Contributor Author

Thanks :)
Happy to take another look at this PR once the other PRs have been merged.

@rahulk29
Copy link
Contributor Author

@dan-fritchman Is there anything blocking merging those PRs?

@dan-fritchman
Copy link
Owner

dan-fritchman commented Feb 13, 2025

PRs #53, #54, and #56 are now merged. Thanks @nanobowers !
@rahulk29 can you roll those changes into your own?

@rahulk29
Copy link
Contributor Author

@dan-fritchman Done!

@rahulk29
Copy link
Contributor Author

@dan-fritchman merge if this is good to go?

@dan-fritchman
Copy link
Owner

MERGE MERGE MERGE

@dan-fritchman dan-fritchman merged commit 52f5be0 into dan-fritchman:main Feb 25, 2025
2 of 5 checks passed
@rahulk29 rahulk29 deleted the rahulk29/lef-via branch February 26, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants