Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the uuid package dependency and replaces it with a custom generateId() implementation that generates cryptographically secure, URL-safe random IDs using Dart's built-in Random.secure().
- Removed the
uuiddependency frompubspec.yaml - Implemented a custom ID generation function in
lib/utils/id.dart - Updated minimum SDK version from
>=3.0.0to>=3.3.0
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/utils/id.dart | New custom ID generator using Random.secure() with 21-character default length and 126 bits of entropy |
| lib/persistor/worker/messages.dart | Replaced uuid.v4() with generateId() for message request IDs |
| lib/broadcast_observer.dart | Replaced uuid.v4() with generateId() for observer IDs |
| lib/collection.dart | Made doc() ID parameter optional, using generateId() as default |
| lib/loon.dart | Replaced import of uuid package with custom id.dart utility, simplified type casting |
| example/lib/random_operation_runner.dart | Replaced uuid.v4() with generateId() for test user IDs |
| test/utils.dart | Removed unused uuid import and constant |
| pubspec.yaml | Removed uuid dependency and bumped minimum SDK version to >=3.3.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2a3f633 to
a778dd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that this library takes some cues from Cloud Firestore, which supports automatically generating IDs, let's add that.