Skip to content

BF: strip away any prefix before ":" while determining numeric dandiset identifier #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
candleindark merged 2 commits into from
Nov 24, 2025
Merged

BF: strip away any prefix before ":" while determining numeric dandiset identifier #1751

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96f056c
BF: strip away any prefix before ":" while determining numeric dandis…
yarikoptic Nov 21, 2025
176eac0
Limit split on : to a single element
yarikoptic Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dandi/dandiset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,9 @@ def _get_identifier(metadata: dict) -> str | None:
id_ = str(id_.get("value", ""))
elif id_ is not None:
assert isinstance(id_, str)
if id_.startswith("DANDI:"):
# result of https://github.com/dandi/dandi-cli/pull/348 which
id_ = id_[len("DANDI:") :]
# result of https://github.com/dandi/dandi-cli/pull/348 which ???
# TODO: RF to avoid this evil!!!
id_ = id_.split(":", maxsplit=1)[-1]

assert id_ is None or isinstance(id_, str)
return id_
Expand Down