Skip to content

Conversation

@joshqsumner
Copy link
Contributor

Describe your changes
Renamed created columns for relpath from config.input_dir from filepath1:N to dir1:N in parallel.parsers.parse_filepath.

Type of update
This is a feature update.

Associated issues
None

Additional context
Also addresses a bug that I think I introduced with the metadata regex stuff as a deepsource fix somewhere along the way related to which pieces of the relpath are used, it was skipping the first one but I think a syntax change upstream made that the wrong thing to do. Might be evidence that it needs more specific tests.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@joshqsumner joshqsumner added bugfix Bug fixes work in progress Mark work in progress update Updates an existing feature/method merge in order Set of PRs that need to be merged sequentially labels Nov 5, 2025
@deepsource-io
Copy link

deepsource-io bot commented Nov 5, 2025

Here's the code health analysis summary for commits 33f8429..cedafb7. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@joshqsumner joshqsumner added ready to review and removed work in progress Mark work in progress labels Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bug fixes merge in order Set of PRs that need to be merged sequentially ready to review update Updates an existing feature/method

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants