WIP: Fix file access for private key and known hosts #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihuguet
reviewed
Dec 22, 2025
Fix files accessed through plugin as root. Identify and fix access to: * Private SSH key file (if key authentication is used) * known_hosts file Make use of nm_utils_copy_cert_as_user() where those files are accessed, then use the copy of the file, instead of the actual file
danfruehauf
force-pushed
the
safe_private_file_access
branch
from
43ae2fa to
1c3f929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix files accessed through plugin as root. Identify and fix access to:
Make use of nm_utils_copy_cert_as_user() where those files are accessed, then use the copy of the file, instead of the actual file
Fixes and addresses #136
Needs to be thoroughly tested.