fix(CreateSkill): improve trigger patterns for natural language matching #448
+12
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add OS detection to support both macOS and Linux filesystem paths. Problem: SessionHarvester hardcoded macOS path structure (-Users-) causing complete failure on Linux systems which use -home- paths. Solution: - Added os module import - Detect platform using os.platform() - Dynamically select path prefix (darwin -> Users, linux -> home) - Updated PROJECTS_DIR construction to use dynamic prefix Testing: - Tested on Linux (Ubuntu) with 857 session transcripts - Maintains macOS compatibility - No breaking changes to existing functionality This fix enables Linux users to harvest learnings from session transcripts, which was previously impossible.
Problem:
ActivityParser.ts hardcoded macOS-specific path pattern `-Users-${USERNAME}--claude`
for the Claude Code projects directory. This fails on Linux systems where the
home directory is `/home/` instead of `/Users/`.
Solution:
- Import `os` module for platform detection
- Use `os.platform()` to detect macOS ("darwin") vs Linux
- Dynamically construct PATH_PREFIX: "Users" on macOS, "home" on Linux
- Replace `require("os")` with proper `os` import for consistency
This is the same fix pattern applied to SessionHarvester.ts.
Tested on:
- Linux (Ubuntu): Correctly resolves to `-home-username--claude`
- Expected macOS behavior: `-Users-username--claude`
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The existing triggers ("create skill", "new skill") failed to match
common natural language patterns like "create a new copywriting skill"
because the noun phrase "copywriting skill" was parsed as the focal
object rather than triggering the CreateSkill workflow.
Updated triggers to match grammatical patterns users actually use:
- "create a skill" / "create a new skill"
- "new skill for" / "build a skill" / "make a skill"
- "skill for managing" / "skill for handling"
- More specific: "canonicalize skill", "validate skill"
Tested with: "Let's create a new copywriting skill" - now triggers correctly.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: Fix CreateSkill Trigger Patterns for Natural Language Matching
Summary
The CreateSkill skill fails to trigger on common natural language patterns like "create a new copywriting skill" because the existing keyword-based triggers don't match how users actually phrase requests.
Problem
Current triggers:
create skill, new skill, skill structure, canonicalizeUser request: "Let's create a new copywriting skill"
What happens: The phrase "copywriting skill" is parsed as the focal noun, so Claude interprets this as a request to help with copywriting rather than invoking the CreateSkill workflow.
Root cause: The triggers are bare keywords that don't account for natural language grammatical patterns where the skill domain (e.g., "copywriting") appears between "create" and "skill".
Solution
Updated triggers to match grammatical patterns users actually use:
create skillcreate a skillnew skillcreate a new skillnew skill forbuild a skillmake a skillskill for managingskill for handlingskill structureskill structurecanonicalizecanonicalize skillvalidate skillChanges
Packs/pai-createskill-skill/src/skills/CreateSkill/SKILL.md- Pack sourceReleases/v2.3/.claude/skills/CreateSkill/SKILL.md- Current releaseTesting
Before fix:
After fix:
Additional test cases that now work:
Risk Assessment
Future Considerations
This is a minimum viable fix to address the immediate triggering failure. The triggers may benefit from further refinement to be more intent-based per Anthropic's guidance on skill descriptions.
Anthropic recommends descriptions that capture user intent rather than specific phrases. A future iteration might explore:
This PR solves the immediate problem while leaving room for a more principled approach if the community wants to explore it.
Checklist