Skip to content

Conversation

@firewave
Copy link
Collaborator

No description provided.

@firewave firewave marked this pull request as draft January 26, 2026 08:11
@sonarqubecloud
Copy link

@firewave firewave marked this pull request as ready for review January 26, 2026 08:44
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. I just wonder if we will write a warning if there is an enum constant which a switch does not cover?
i.e. remove a case ShowTypes::ShowNone: and the related code, do we warn then?

@firewave
Copy link
Collaborator Author

I like it. I just wonder if we will write a warning if there is an enum constant which a switch does not cover? i.e. remove a case ShowTypes::ShowNone: and the related code, do we warn then?

Yup.

/home/user/CLionProjects/cppcheck/gui/checkstatistics.cpp:42:13: warning: enumeration value 'ShowNone' not handled in switch [-Wswitch]
   42 |     switch (type) {
      |             ^~~~

@firewave firewave merged commit 6369e51 into danmar:main Jan 29, 2026
66 checks passed
@firewave firewave deleted the switch-default branch January 29, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants