Skip to content

small cleanup of disabled Clang compiler warnings #8166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
firewave wants to merge 3 commits into
base: main
Choose a base branch
from
Open

small cleanup of disabled Clang compiler warnings #8166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7179e6
enabled some Clang compiler warnings
firewave Jan 26, 2026
5dd4b60
json.h: suppress `-Wimplicit-float-conversion` Clang warnings
firewave Jan 26, 2026
3167ff5
tinyxml2/CMakeLists.txt: disabled some Clang compiler warnings
firewave Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions cmake/compileroptions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,6 @@ elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
endif()

# TODO: fix and enable these warnings - or move to suppression list below
add_compile_options_safe(-Wno-documentation-unknown-command) # TODO: Clang currently does not support all commands
add_compile_options_safe(-Wno-unused-exception-parameter)
add_compile_options_safe(-Wno-sign-conversion)
add_compile_options_safe(-Wno-shadow-field-in-constructor)
add_compile_options_safe(-Wno-shorten-64-to-32)
Expand Down
2 changes: 2 additions & 0 deletions externals/tinyxml2/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
target_compile_options_safe(tinyxml2 -Wno-zero-as-null-pointer-constant)
target_compile_options_safe(tinyxml2 -Wno-format-nonliteral)
target_compile_options_safe(tinyxml2 -Wno-inconsistent-missing-destructor-override)
target_compile_options_safe(tinyxml2 -Wno-sign-conversion)
target_compile_options_safe(tinyxml2 -Wno-double-promotion)
endif()
if(CYGWIN)
target_compile_definitions(-D_LARGEFILE_SOURCE) # required for fseeko() and ftello()
Expand Down
2 changes: 2 additions & 0 deletions lib/json.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ SUPPRESS_WARNING_CLANG_PUSH("-Wextra-semi-stmt")
SUPPRESS_WARNING_CLANG_PUSH("-Wzero-as-null-pointer-constant")
SUPPRESS_WARNING_CLANG_PUSH("-Wformat")
SUPPRESS_WARNING_CLANG_PUSH("-Wfloat-conversion")
SUPPRESS_WARNING_CLANG_PUSH("-Wimplicit-float-conversion")

#define PICOJSON_USE_INT64
#include <picojson.h> // IWYU pragma: export
Expand All @@ -37,6 +38,7 @@ SUPPRESS_WARNING_CLANG_POP
SUPPRESS_WARNING_CLANG_POP
SUPPRESS_WARNING_CLANG_POP
SUPPRESS_WARNING_CLANG_POP
SUPPRESS_WARNING_CLANG_POP
SUPPRESS_WARNING_GCC_POP
SUPPRESS_WARNING_POP

Expand Down
Loading