Open
Conversation
pablomendezroyo
requested changes
Dec 23, 2025
pablomendezroyo
left a comment
pablomendezroyo
left a comment
There was a problem hiding this comment.
Could you resolve the conflicts? we have been implementing changes recently
thanks for the contribution!
Marketen
reviewed
Dec 23, 2025
| { | ||
| "name": "juno.dnp.dappnode.eth", | ||
| "version": "0.1.0", | ||
| "version": "2.0.3", |
There was a problem hiding this comment.
This version is not the upstream (starknet-staking) one, its the dappnode package version. So current dappnode "starknetstaking" package is 0.1.0, next should be 0.1.1
Author
There was a problem hiding this comment.
The version was following the numbering on the original repository. I rolled it back to 0.1.2
lgaroche
force-pushed
the
feat/starknet-staking
branch
from
27f4ec8 to
d3e1fda
Compare
Author
|
Rebased on main to include latest updates. Also bumped the staking upstream package version to 0.3.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Nethermind's Starknet Staking v2 package, with signer configuration and metrics.
Remarks: