-
Notifications
You must be signed in to change notification settings - Fork 224
Adding DaprSpringBootTest and DaprSidecarContainer annotation for easier ITs authoring #1610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ier IT authoring. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
|
@dapr/maintainers-java-sdk and @dapr/approvers-java-sdk could you please take a look. I think this is a really important improvement for ITs and Testcontainers integration. @salaboy and @javier-aliaga could you please take a look. Thank you. |
|
@artur-ciocanu great stuff.. as always.. I am not saying that these improvements are not good. I am just worried on going too deep into simplifications where it looks odd for spring users. For example |
@salaboy your suggestion is that we do not try to compose annotations, so we do not confuse SpringBoot users. I get your point. I wanted to make sure that we can simplify some of this random port and sidecar dependency, but I guess since we want it just for us we can push it to it as a helper, outside of the Dapr Testconainer module, what do you think? |
…ier IT authoring. Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
|
Yeah so let's split what the end user will use to create end user tests and the functionality that we want to have for our own tests to make them easier |
…posing it as public API Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
|
@salaboy the helper annotations and classes have been moved to "sdk-tests" module, now these should not conflict with "testcontainers-dapr" module. Let me know your thoughts. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1610 +/- ##
============================================
+ Coverage 76.91% 78.65% +1.74%
- Complexity 1592 1958 +366
============================================
Files 145 217 +72
Lines 4843 5970 +1127
Branches 562 661 +99
============================================
+ Hits 3725 4696 +971
- Misses 821 934 +113
- Partials 297 340 +43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This PR adds two major improvements:
Currently only a single IT has been migrated to showcase how things are looking.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: N/A
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: