Skip to content

Conversation

@escaton
Copy link

@escaton escaton commented Feb 7, 2016

No description provided.

@daraosn
Copy link
Owner

daraosn commented Feb 7, 2016

I made this repository some years ago, when there wasn't any Node.js zip library. I found the project JSZip, they made a great job porting zip/unzip archiving functionality, but it used to work only on browsers. That's why I made this repo, but now things have changed and JSZip I think it works with node, but this module is used at many projects (I didn't expect this to be honest).

Accepting your pull request could potentially break many dependent projects that rely on this functionality (we could think on a version bump maybe).

I would rather wait a bit and ask to see if more people are okay with the change.

@trufae
Copy link

trufae commented Sep 13, 2016

just bump the big version number and projects should carefully upgrade. breaking api shouldnt be a problem if proper documentation is provided, and this change is trivial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants