fix broken stuff #19
Merged
fix broken stuff #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fixes
Correlation heatmap hanging indefinitely - Use X_train_pca instead of unintentional X_train
Heatmap colors compressed/invisible - Auto-scale vmin/vmax from actual data instead of fixed -1/1
PCA attribute not actually correct - Changed n_components to n_components_ (sklearn convention)
Bunch of type errors everywhere - fixed
Program crashes on missing directories like assets / models - Added mkdir(parents=True, exist_ok=True)
Prediction flow broken - Fixed to pass Dataset + vae_type to features() instead of array
New Features
Feature dataset caching - dataset + model hash based caching into .cache/features/
Fallback for empty assets folder - Added check for local images, fallback to placeholder dataset (a-slice)