Skip to content

Fix graceful shutdown race condition #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Jul 30, 2025
Merged

Fix graceful shutdown race condition #362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/broadway/topology/terminator.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ defmodule Broadway.Topology.Terminator do

@spec trap_exit(GenServer.server()) :: :ok
def trap_exit(terminator) do
GenServer.cast(terminator, :trap_exit)
GenServer.call(terminator, :trap_exit)
end

@impl true
Expand All @@ -24,9 +24,9 @@ defmodule Broadway.Topology.Terminator do
end

@impl true
def handle_cast(:trap_exit, state) do
def handle_call(:trap_exit, _from, state) do
Process.flag(:trap_exit, true)
{:noreply, state}
{:reply, :ok, state}
end

@impl true
Expand Down
Loading