feat(dip-18): add distinct type byte prefixes

[thephez]

• Change type bytes to 0xb0 (P2PKH) and 0x80 (P2SH) for visually distinct prefixes:
  • P2PKH addresses start with k (e.g., evo1k...)
  • P2SH addresses start with s (e.g., evo1s...)
• Update test vectors and reference implementation

Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com

Summary by CodeRabbit

• Documentation

  • Address encoding specification updated with new type-byte scheme, expanded "Type byte meaning" table, visual-address-pattern examples, reserved type-byte ranges, and guidance for hardware displays.

• Tests

  • Address test vectors and payload examples updated for mainnet and testnet to reflect revised type-byte values.

• Other

  • Hardware wallet address validation and display guidance updated; added a type-byte calculation utility reference.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Updated Dash address type-byte encoding from 0x00/0x01 to 0xb0/0x80 across spec and implementation; adjusted bech32 mappings, test vectors, payload construction, validation rules, hardware-wallet guidance, and added a type-byte calculation utility script.

Changes

Cohort / File(s)	Summary
Specification Documentation dip-0018.md	Replaced type-byte references 0x00/0x01 with 0xb0/0x80 throughout; updated payload construction, bech32m handling, validation checks, first-character/type table, reserved ranges, examples, test vectors, and hardware wallet display guidance.
Bech32 Implementation dip-0018/bech32.py	Updated TYPE_TO_BYTE mapping (p2pkh: 0x00 → 0xb0, p2sh: 0x01 → 0x80) and regenerated BYTE_TO_TYPE mapping and test expectations accordingly.
Type-byte Tooling dip-0018/type_byte_calc.py	Added new helper script with CHARSET, convertbits, find_type_byte_for_char, and show_encoding_for_type_byte to search and display type-bytes that produce desired first bech32 characters; includes demonstration output.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: introducing distinct type byte prefixes (0xb0 for P2PKH and 0x80 for P2SH) to enable visually distinct address formats.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[thephez]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[thephez]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.