-
Notifications
You must be signed in to change notification settings - Fork 45
chore: merge v2.1.2 into v2.2-dev #2828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ gRPC Query Coverage Report |
|
Caution Review failedThe pull request is closed. WalkthroughVersion bump from 2.1.1 to 2.1.2 across all packages with corresponding changelog entry. Dashmate refactored to support multiple platform profiles dynamically via a new options parameter in profile selection logic. Minor documentation formatting in Platform.pbobjc.h. Changes
Sequence Diagram(s)sequenceDiagram
participant resetTask as resetNodeTask
participant getConfigProfiles as getConfigProfiles(config, options)
participant selectProfiles as selectPlatformProfiles(config, options)
participant dockerCompose as dockerCompose
rect rgb(230, 245, 255)
Note over resetTask: ctx.isPlatformOnlyReset = true
resetTask->>selectProfiles: selectPlatformProfiles(config, {includeAll: true})
selectProfiles->>getConfigProfiles: getConfigProfiles(config, {includeAll: true})
getConfigProfiles-->>selectProfiles: [platform-dapi-deprecated, platform-dapi-rs]
selectProfiles-->>resetTask: [platform-dapi-deprecated, platform-dapi-rs]
resetTask->>dockerCompose: isNodeRunning(profiles)
end
rect rgb(245, 230, 255)
Note over resetTask: Remove platform services
resetTask->>dockerCompose: rm(profiles)
resetTask->>dockerCompose: getVolumeNames(profiles)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (66)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ DashSDKFFI.xcframework built for this PR.
SwiftPM (host the zip at a stable URL, then use): .binaryTarget(
name: "DashSDKFFI",
url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
checksum: "38e3d285e81b1176733c2b20e9f0bb8061dacf831a3ac88aa22379d15166cf43"
)Xcode manual integration:
|
Issue being fixed or feature implemented
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit
Bug Fixes
Chores