Skip to content

Conversation

@shumkov
Copy link
Collaborator

@shumkov shumkov commented Nov 28, 2025

Issue being fixed or feature implemented

Release new Dash Platform version

What was done?

  • Updated changelog
  • Bumped packages version

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • Chores

    • Bumped workspace and package versions to 2.2.0-dev.2 across the repository.
  • Documentation

    • Added/updated changelog entries for 2.2.0-dev.2 covering breaking changes, new features, bug fixes, tests, build system notes, and refactoring items.

✏️ Tip: You can customize this high-level summary in your review settings.

@shumkov shumkov added this to the v2.2.0 milestone Nov 28, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 28, 2025

Walkthrough

Bumps the monorepo version to 2.2.0-dev.2: updates Cargo.toml, the root package.json, many packages/*/package.json files, and appends a new 2.2.0-dev.2 section to CHANGELOG.md (breaking changes, features, bug fixes, tests, build, refactors).

Changes

Cohort / File(s) Summary
Changelog
CHANGELOG.md
Added new changelog section for version 2.2.0-dev.2 listing BREAKING CHANGES, Features, Bug Fixes, Tests, Build System, and Code Refactoring items
Workspace manifest
Cargo.toml
Bumped workspace package version from 2.2.0-dev.12.2.0-dev.2
Root package
package.json
Bumped root package version from 2.2.0-dev.12.2.0-dev.2
Monorepo package.json files
packages/*/package.json (multiple files)
Version field incremented across many packages — most from 2.2.0-dev.12.2.0-dev.2; scoped exceptions: packages/dash-spv/package.json (3.2.0-dev.1 → 3.2.0-dev.2), packages/js-dash-sdk/package.json (5.2.0-dev.1 → 5.2.0-dev.2), packages/wallet-lib/package.json (9.2.0-dev.1 → 9.2.0-dev.2), packages/wasm-dpp2/package.json (2.1.0-dev.8 → 2.2.0-dev.2)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Homogeneous, mechanical version bumps and a documentation addition.
  • Review attention: verify no unintended non-version edits in CHANGELOG.md and confirm the specific wasm-dpp2 version change (was 2.1.0-dev.8 → 2.2.0-dev.2) matches release intent.

Possibly related PRs

Suggested reviewers

  • QuantumExplorer
  • lklimek

Poem

🐰 I hopped through files with careful paws,

bumped versions, wrote notes, observed the laws.
Cargo and packages lined in a row,
changelog whispers of features to show.
A tiny bump — a soft spring-time hop! 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title clearly describes the main change: updating the changelog and bumping version to 2.2.0-dev.2, which directly corresponds to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release_2.2.0-dev.2

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 68de916 and cb54f8f.

📒 Files selected for processing (1)
  • packages/wasm-dpp2/package.json (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-03T14:42:29.958Z
Learnt from: thephez
Repo: dashpay/platform PR: 2754
File: packages/wasm-sdk/docs.html:1970-1971
Timestamp: 2025-09-03T14:42:29.958Z
Learning: In packages/wasm-sdk/, the docs.html file is auto-generated from api-definitions.json. Any documentation fixes should be made in api-definitions.json rather than directly in docs.html, as manual changes to docs.html would be overwritten during regeneration.

Applied to files:

  • packages/wasm-dpp2/package.json
📚 Learning: 2025-09-03T14:41:16.196Z
Learnt from: thephez
Repo: dashpay/platform PR: 2754
File: packages/wasm-sdk/AI_REFERENCE.md:766-766
Timestamp: 2025-09-03T14:41:16.196Z
Learning: In packages/wasm-sdk/, the AI_REFERENCE.md file is auto-generated from api-definitions.json. Any documentation fixes should be made in api-definitions.json rather than directly in AI_REFERENCE.md, as manual changes to AI_REFERENCE.md would be overwritten during regeneration.

Applied to files:

  • packages/wasm-dpp2/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (186)
  • GitHub Check: Rust packages (dapi-grpc) / Detect immutable structure changes
  • GitHub Check: Rust packages (token-history-contract) / Linting
  • GitHub Check: Rust packages (token-history-contract) / Tests
  • GitHub Check: Rust packages (token-history-contract) / Unused dependencies
  • GitHub Check: Rust packages (wasm-sdk) / Formatting
  • GitHub Check: Rust packages (wasm-sdk) / Tests
  • GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
  • GitHub Check: Rust packages (wasm-sdk) / Linting
  • GitHub Check: Rust packages (dash-sdk) / Tests
  • GitHub Check: Rust packages (wasm-dpp) / Tests
  • GitHub Check: Rust packages (wasm-dpp) / Unused dependencies
  • GitHub Check: Rust packages (wasm-dpp) / Linting
  • GitHub Check: Rust packages (withdrawals-contract) / Unused dependencies
  • GitHub Check: Rust packages (dashpay-contract) / Tests
  • GitHub Check: Rust packages (dashpay-contract) / Unused dependencies
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
  • GitHub Check: Build JS packages / Build JS
  • GitHub Check: Rust packages (dapi-grpc) / Detect immutable structure changes
  • GitHub Check: Rust packages (token-history-contract) / Linting
  • GitHub Check: Rust packages (token-history-contract) / Tests
  • GitHub Check: Rust packages (token-history-contract) / Unused dependencies
  • GitHub Check: Rust packages (wasm-sdk) / Formatting
  • GitHub Check: Rust packages (wasm-sdk) / Tests
  • GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
  • GitHub Check: Rust packages (wasm-sdk) / Linting
  • GitHub Check: Rust packages (dash-sdk) / Tests
  • GitHub Check: Rust packages (wasm-dpp) / Tests
  • GitHub Check: Rust packages (wasm-dpp) / Unused dependencies
  • GitHub Check: Rust packages (wasm-dpp) / Linting
  • GitHub Check: Rust packages (withdrawals-contract) / Unused dependencies
  • GitHub Check: Rust packages (dashpay-contract) / Tests
  • GitHub Check: Rust packages (dashpay-contract) / Unused dependencies
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
  • GitHub Check: Build JS packages / Build JS
  • GitHub Check: Rust packages (dapi-grpc) / Detect immutable structure changes
  • GitHub Check: Rust packages (token-history-contract) / Linting
  • GitHub Check: Rust packages (token-history-contract) / Tests
  • GitHub Check: Rust packages (token-history-contract) / Unused dependencies
  • GitHub Check: Rust packages (wasm-sdk) / Formatting
  • GitHub Check: Rust packages (wasm-sdk) / Tests
  • GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
  • GitHub Check: Rust packages (wasm-sdk) / Linting
  • GitHub Check: Rust packages (dash-sdk) / Tests
  • GitHub Check: Rust packages (wasm-dpp) / Tests
  • GitHub Check: Rust packages (wasm-dpp) / Unused dependencies
  • GitHub Check: Rust packages (wasm-dpp) / Linting
  • GitHub Check: Rust packages (withdrawals-contract) / Unused dependencies
  • GitHub Check: Rust packages (dashpay-contract) / Tests
  • GitHub Check: Rust packages (dashpay-contract) / Unused dependencies
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
  • GitHub Check: Build JS packages / Build JS
  • GitHub Check: Rust packages (token-history-contract) / Linting
  • GitHub Check: Rust packages (token-history-contract) / Tests
  • GitHub Check: Rust packages (token-history-contract) / Unused dependencies
  • GitHub Check: Rust packages (wasm-sdk) / Formatting
  • GitHub Check: Rust packages (wasm-sdk) / Tests
  • GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
  • GitHub Check: Rust packages (wasm-sdk) / Linting
  • GitHub Check: Rust packages (dash-sdk) / Tests
  • GitHub Check: Rust packages (wasm-dpp) / Tests
  • GitHub Check: Rust packages (wasm-dpp) / Unused dependencies
  • GitHub Check: Rust packages (wasm-dpp) / Linting
  • GitHub Check: Rust packages (withdrawals-contract) / Unused dependencies
  • GitHub Check: Rust packages (dashpay-contract) / Tests
  • GitHub Check: Rust packages (dashpay-contract) / Unused dependencies
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
  • GitHub Check: Build JS packages / Build JS
  • GitHub Check: Rust packages (token-history-contract) / Linting
  • GitHub Check: Rust packages (token-history-contract) / Tests
  • GitHub Check: Rust packages (token-history-contract) / Unused dependencies
  • GitHub Check: Rust packages (wasm-sdk) / Formatting
  • GitHub Check: Rust packages (wasm-sdk) / Tests
  • GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
  • GitHub Check: Rust packages (wasm-sdk) / Linting
  • GitHub Check: Rust packages (dash-sdk) / Tests
  • GitHub Check: Rust packages (wasm-dpp) / Tests
  • GitHub Check: Rust packages (wasm-dpp) / Unused dependencies
  • GitHub Check: Rust packages (wasm-dpp) / Linting
  • GitHub Check: Rust packages (withdrawals-contract) / Unused dependencies
  • GitHub Check: Rust packages (dashpay-contract) / Tests
  • GitHub Check: Rust packages (dashpay-contract) / Unused dependencies
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
  • GitHub Check: Build JS packages / Build JS
  • GitHub Check: Rust packages (dapi-grpc) / Unused dependencies
  • GitHub Check: Rust packages (token-history-contract) / Linting
  • GitHub Check: Rust packages (token-history-contract) / Tests
  • GitHub Check: Rust packages (token-history-contract) / Unused dependencies
  • GitHub Check: Rust packages (wasm-sdk) / Formatting
  • GitHub Check: Rust packages (wasm-sdk) / Tests
  • GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
  • GitHub Check: Rust packages (wasm-sdk) / Linting
  • GitHub Check: Rust packages (dash-sdk) / Tests
  • GitHub Check: Rust packages (wasm-dpp) / Tests
  • GitHub Check: Rust packages (wasm-dpp) / Unused dependencies
  • GitHub Check: Rust packages (wasm-dpp) / Linting
  • GitHub Check: Rust packages (withdrawals-contract) / Unused dependencies
  • GitHub Check: Rust packages (dashpay-contract) / Tests
  • GitHub Check: Rust packages (dashpay-contract) / Unused dependencies
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
  • GitHub Check: Build JS packages / Build JS
  • GitHub Check: Rust packages (dapi-grpc) / Unused dependencies
  • GitHub Check: Rust packages (token-history-contract) / Linting
  • GitHub Check: Rust packages (token-history-contract) / Tests
  • GitHub Check: Rust packages (token-history-contract) / Unused dependencies
  • GitHub Check: Rust packages (wasm-sdk) / Formatting
  • GitHub Check: Rust packages (wasm-sdk) / Tests
  • GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
  • GitHub Check: Rust packages (wasm-sdk) / Linting
  • GitHub Check: Rust packages (dash-sdk) / Tests
  • GitHub Check: Rust packages (wasm-dpp) / Tests
  • GitHub Check: Rust packages (wasm-dpp) / Unused dependencies
  • GitHub Check: Rust packages (wasm-dpp) / Linting
  • GitHub Check: Rust packages (withdrawals-contract) / Unused dependencies
  • GitHub Check: Rust packages (dashpay-contract) / Tests
  • GitHub Check: Rust packages (dashpay-contract) / Unused dependencies
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
  • GitHub Check: Build JS packages / Build JS
  • GitHub Check: Rust packages (dapi-grpc) / Unused dependencies
  • GitHub Check: Rust packages (token-history-contract) / Linting
  • GitHub Check: Rust packages (token-history-contract) / Tests
  • GitHub Check: Rust packages (token-history-contract) / Unused dependencies
  • GitHub Check: Rust packages (wasm-sdk) / Formatting
  • GitHub Check: Rust packages (wasm-sdk) / Tests
  • GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
  • GitHub Check: Rust packages (wasm-sdk) / Linting
  • GitHub Check: Rust packages (dash-sdk) / Tests
  • GitHub Check: Rust packages (wasm-dpp) / Tests
  • GitHub Check: Rust packages (wasm-dpp) / Unused dependencies
  • GitHub Check: Rust packages (wasm-dpp) / Linting
  • GitHub Check: Rust packages (withdrawals-contract) / Unused dependencies
  • GitHub Check: Rust packages (dashpay-contract) / Tests
  • GitHub Check: Rust packages (dashpay-contract) / Unused dependencies
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
  • GitHub Check: Build JS packages / Build JS
  • GitHub Check: Rust packages (dapi-grpc) / Unused dependencies
  • GitHub Check: Rust packages (token-history-contract) / Linting
  • GitHub Check: Rust packages (token-history-contract) / Tests
  • GitHub Check: Rust packages (token-history-contract) / Unused dependencies
  • GitHub Check: Rust packages (wasm-sdk) / Formatting
  • GitHub Check: Rust packages (wasm-sdk) / Tests
  • GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
  • GitHub Check: Rust packages (wasm-sdk) / Linting
  • GitHub Check: Rust packages (dash-sdk) / Tests
  • GitHub Check: Rust packages (wasm-dpp) / Tests
  • GitHub Check: Rust packages (wasm-dpp) / Unused dependencies
  • GitHub Check: Rust packages (wasm-dpp) / Linting
  • GitHub Check: Rust packages (withdrawals-contract) / Unused dependencies
  • GitHub Check: Rust packages (dashpay-contract) / Tests
  • GitHub Check: Rust packages (dashpay-contract) / Unused dependencies
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
  • GitHub Check: Build JS packages / Build JS
  • GitHub Check: Rust packages (dapi-grpc) / Unused dependencies
  • GitHub Check: Rust packages (token-history-contract) / Linting
  • GitHub Check: Rust packages (token-history-contract) / Tests
  • GitHub Check: Rust packages (token-history-contract) / Unused dependencies
  • GitHub Check: Rust packages (wasm-sdk) / Formatting
  • GitHub Check: Rust packages (wasm-sdk) / Tests
  • GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
  • GitHub Check: Rust packages (wasm-sdk) / Linting
  • GitHub Check: Rust packages (dash-sdk) / Tests
  • GitHub Check: Rust packages (wasm-dpp) / Tests
  • GitHub Check: Rust packages (wasm-dpp) / Unused dependencies
  • GitHub Check: Rust packages (wasm-dpp) / Linting
  • GitHub Check: Rust packages (dashpay-contract) / Tests
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
  • GitHub Check: Build JS packages / Build JS
🔇 Additional comments (1)
packages/wasm-dpp2/package.json (1)

3-3: Version field correctly bumped to 2.2.0-dev.2.

The version update aligns with the PR objectives and the coordinated version increment documented in the AI summary across the monorepo (Cargo.toml, root package.json, other packages, and CHANGELOG.md). No other fields were modified, preserving the rest of the package configuration.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (2)
CHANGELOG.md (2)

6-6: Add missing scope or align wording.

“use identity contract keys query” appears without a scope in BREAKING CHANGES and Code Refactoring. Consider adding a scope prefix (e.g., platform/dapi/sdk) or clarifying which component changed, to match the house style used elsewhere.

Also applies to: 46-46


6-9: Deduplicate entries and confirm classification.

  • “dashmate: port conflicts …” is listed under both BREAKING CHANGES and Bug Fixes. Pick one (likely Bug Fix) or explain why it’s breaking.
  • “sdk: cleanup …” and “sdk: user‑friendly …” are listed under both BREAKING CHANGES and Code Refactoring. If they are breaking, keep under BREAKING and drop from Refactoring to avoid repetition.

Also applies to: 41-46, 20-20

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 37cc2cd and 68de916.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (26)
  • CHANGELOG.md (1 hunks)
  • Cargo.toml (1 hunks)
  • package.json (1 hunks)
  • packages/bench-suite/package.json (1 hunks)
  • packages/dapi-grpc/package.json (1 hunks)
  • packages/dapi/package.json (1 hunks)
  • packages/dash-spv/package.json (1 hunks)
  • packages/dashmate/package.json (1 hunks)
  • packages/dashpay-contract/package.json (1 hunks)
  • packages/dpns-contract/package.json (1 hunks)
  • packages/feature-flags-contract/package.json (1 hunks)
  • packages/js-dapi-client/package.json (1 hunks)
  • packages/js-dash-sdk/package.json (1 hunks)
  • packages/js-evo-sdk/package.json (1 hunks)
  • packages/js-grpc-common/package.json (1 hunks)
  • packages/keyword-search-contract/package.json (1 hunks)
  • packages/masternode-reward-shares-contract/package.json (1 hunks)
  • packages/platform-test-suite/package.json (1 hunks)
  • packages/token-history-contract/package.json (1 hunks)
  • packages/wallet-lib/package.json (1 hunks)
  • packages/wallet-utils-contract/package.json (1 hunks)
  • packages/wasm-dpp/package.json (1 hunks)
  • packages/wasm-dpp2/package.json (1 hunks)
  • packages/wasm-drive-verify/package.json (1 hunks)
  • packages/wasm-sdk/package.json (1 hunks)
  • packages/withdrawals-contract/package.json (1 hunks)
🧰 Additional context used
🧠 Learnings (18)
📓 Common learnings
Learnt from: CR
Repo: dashpay/platform PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T13:10:23.481Z
Learning: Use Yarn workspaces to manage multiple packages in the monorepo structure
📚 Learning: 2025-09-22T05:59:31.140Z
Learnt from: shumkov
Repo: dashpay/platform PR: 2783
File: packages/js-evo-sdk/tests/functional/dpns.spec.mjs:2-2
Timestamp: 2025-09-22T05:59:31.140Z
Learning: The dist/evo-sdk.module.js file in packages/js-evo-sdk is a generated build artifact created during the build process, not a source file that should exist in the repository.

Applied to files:

  • packages/js-evo-sdk/package.json
📚 Learning: 2025-11-25T13:10:23.481Z
Learnt from: CR
Repo: dashpay/platform PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T13:10:23.481Z
Learning: Use JavaScript/TypeScript for client SDKs, developer tools, and test suite

Applied to files:

  • packages/js-evo-sdk/package.json
  • packages/wasm-sdk/package.json
📚 Learning: 2025-10-23T13:04:39.160Z
Learnt from: thephez
Repo: dashpay/platform PR: 2816
File: packages/js-dapi-client/lib/networkConfigs.js:17-40
Timestamp: 2025-10-23T13:04:39.160Z
Learning: For the testnet DAPI address whitelist in packages/js-dapi-client/lib/networkConfigs.js, nodes may be intentionally excluded even if they are ENABLED if they are running pre-2.1 versions. Version compatibility is an important filtering criterion beyond just enabled status.

Applied to files:

  • packages/dapi/package.json
  • packages/dapi-grpc/package.json
📚 Learning: 2025-10-15T14:45:30.856Z
Learnt from: lklimek
Repo: dashpay/platform PR: 2716
File: packages/dashmate/src/test/constants/services.js:4-4
Timestamp: 2025-10-15T14:45:30.856Z
Learning: In the dashmate codebase (packages/dashmate), during the DAPI Rust migration (rs-dapi), the old service keys `dapi_api` and `dapi_core_streams` are intentionally kept in `generateEnvsFactory.js` for backward compatibility even though the test constants in `src/test/constants/services.js` have been updated to use `rs_dapi`. These deprecated keys will be removed in a future PR after the transition is complete.

Applied to files:

  • packages/dapi/package.json
  • packages/dashmate/package.json
  • CHANGELOG.md
📚 Learning: 2025-09-03T14:41:16.196Z
Learnt from: thephez
Repo: dashpay/platform PR: 2754
File: packages/wasm-sdk/AI_REFERENCE.md:766-766
Timestamp: 2025-09-03T14:41:16.196Z
Learning: In packages/wasm-sdk/, the AI_REFERENCE.md file is auto-generated from api-definitions.json. Any documentation fixes should be made in api-definitions.json rather than directly in AI_REFERENCE.md, as manual changes to AI_REFERENCE.md would be overwritten during regeneration.

Applied to files:

  • packages/wasm-sdk/package.json
  • packages/wasm-dpp2/package.json
  • packages/wasm-drive-verify/package.json
📚 Learning: 2025-09-03T14:42:29.958Z
Learnt from: thephez
Repo: dashpay/platform PR: 2754
File: packages/wasm-sdk/docs.html:1970-1971
Timestamp: 2025-09-03T14:42:29.958Z
Learning: In packages/wasm-sdk/, the docs.html file is auto-generated from api-definitions.json. Any documentation fixes should be made in api-definitions.json rather than directly in docs.html, as manual changes to docs.html would be overwritten during regeneration.

Applied to files:

  • packages/wasm-sdk/package.json
  • packages/wasm-dpp2/package.json
  • packages/wasm-drive-verify/package.json
📚 Learning: 2025-10-29T11:37:57.299Z
Learnt from: lklimek
Repo: dashpay/platform PR: 2818
File: packages/dashmate/test/unit/templates/dynamicCompose.spec.js:1-4
Timestamp: 2025-10-29T11:37:57.299Z
Learning: In the dashpay/platform repository's dashmate package (packages/dashmate), test files do not need to import `expect` from chai because test/bootstrap.js sets it up globally with `global.expect = expect;`. The bootstrap file is automatically loaded by Mocha.

Applied to files:

  • packages/platform-test-suite/package.json
📚 Learning: 2024-10-09T00:22:57.778Z
Learnt from: shumkov
Repo: dashpay/platform PR: 2206
File: packages/rs-platform-version/src/version/protocol_version.rs:155-157
Timestamp: 2024-10-09T00:22:57.778Z
Learning: In the dashmate default configurations, the default protocol version for local networks has been removed, and an update mechanism for the protocol version in the consensus parameters has been implemented.

Applied to files:

  • packages/dashmate/package.json
📚 Learning: 2024-10-17T08:52:54.300Z
Learnt from: shumkov
Repo: dashpay/platform PR: 2248
File: packages/rs-drive-abci/src/main.rs:106-111
Timestamp: 2024-10-17T08:52:54.300Z
Learning: In this project, the environment variable `CARGO_PKG_RUST_VERSION` is defined and can be used safely with the `env!` macro.

Applied to files:

  • Cargo.toml
📚 Learning: 2025-11-25T13:10:23.481Z
Learnt from: CR
Repo: dashpay/platform PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T13:10:23.481Z
Learning: Run Rust tests for packages using `cargo test -p <package_name>` and all Rust tests with `cargo test --workspace`

Applied to files:

  • Cargo.toml
📚 Learning: 2024-10-18T15:39:51.172Z
Learnt from: lklimek
Repo: dashpay/platform PR: 2254
File: packages/rs-sdk/src/sdk.rs:585-585
Timestamp: 2024-10-18T15:39:51.172Z
Learning: The 'platform' project uses Rust version 1.80, so code in 'packages/rs-sdk' can use features available in Rust 1.80, such as the `abs_diff()` method.

Applied to files:

  • Cargo.toml
📚 Learning: 2025-01-19T07:36:46.042Z
Learnt from: QuantumExplorer
Repo: dashpay/platform PR: 2431
File: packages/rs-drive/Cargo.toml:55-60
Timestamp: 2025-01-19T07:36:46.042Z
Learning: The grovedb dependencies in packages/rs-drive/Cargo.toml and related files are intentionally kept at specific revisions rather than using the latest stable version, with plans to update them at a later time.

Applied to files:

  • Cargo.toml
📚 Learning: 2025-10-09T16:00:42.724Z
Learnt from: lklimek
Repo: dashpay/platform PR: 2716
File: packages/rs-dash-event-bus/Cargo.toml:4-4
Timestamp: 2025-10-09T16:00:42.724Z
Learning: Rust edition 2024 was released and stabilized in Rust 1.85 on February 20, 2025. Using `edition = "2024"` in Cargo.toml is valid and supported.

Applied to files:

  • Cargo.toml
📚 Learning: 2025-11-25T13:10:23.481Z
Learnt from: CR
Repo: dashpay/platform PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T13:10:23.481Z
Learning: Applies to **/*.rs : Rust code must pass `cargo clippy --workspace` linter checks

Applied to files:

  • Cargo.toml
📚 Learning: 2025-11-25T13:10:23.481Z
Learnt from: CR
Repo: dashpay/platform PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-25T13:10:23.481Z
Learning: Applies to **/swift-sdk/**/*.{swift,h,m,c} : iOS SDK must combine both Core (SPV wallet) and Platform (identity/documents) functionality in the unified SDK with proper function naming: `dash_core_sdk_*` prefix for Core functions, `dash_sdk_*` prefix for Platform functions, and `dash_unified_sdk_*` prefix for unified functions

Applied to files:

  • CHANGELOG.md
📚 Learning: 2025-03-11T09:39:23.071Z
Learnt from: shumkov
Repo: dashpay/platform PR: 2489
File: packages/rs-dpp/Cargo.toml:32-32
Timestamp: 2025-03-11T09:39:23.071Z
Learning: In the Dash Platform project, dependencies are currently managed using Git repository references with tags (repo+tag format in Cargo.toml) rather than published crates, as the team is not currently publishing crates to crates.io.

Applied to files:

  • packages/js-dash-sdk/package.json
📚 Learning: 2025-07-10T00:37:09.586Z
Learnt from: QuantumExplorer
Repo: dashpay/platform PR: 2690
File: packages/wasm-sdk/src/queries/document.rs:383-384
Timestamp: 2025-07-10T00:37:09.586Z
Learning: In the Dash platform, DPNS (Dash Platform Name Service) contracts have the same ID across all networks (mainnet, testnet, etc.), so hardcoding the DPNS contract ID is appropriate and doesn't need to be configurable.

Applied to files:

  • packages/dpns-contract/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (138)
  • GitHub Check: Rust packages (dashpay-contract) / Unused dependencies
  • GitHub Check: Rust packages (drive) / Tests
  • GitHub Check: Rust packages (wallet-utils-contract) / Tests
  • GitHub Check: Rust packages (wallet-utils-contract) / Linting
  • GitHub Check: Rust packages (wallet-utils-contract) / Unused dependencies
  • GitHub Check: Rust packages (wasm-dpp2) / Tests
  • GitHub Check: Rust packages (wasm-dpp2) / Linting
  • GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
  • GitHub Check: Rust packages (wasm-sdk) / Linting
  • GitHub Check: Rust packages (wasm-sdk) / Tests
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
  • GitHub Check: Rust packages (dashpay-contract) / Unused dependencies
  • GitHub Check: Rust packages (drive) / Tests
  • GitHub Check: Rust packages (wallet-utils-contract) / Tests
  • GitHub Check: Rust packages (wallet-utils-contract) / Linting
  • GitHub Check: Rust packages (wallet-utils-contract) / Unused dependencies
  • GitHub Check: Rust packages (wasm-dpp2) / Tests
  • GitHub Check: Rust packages (wasm-sdk) / Unused dependencies
  • GitHub Check: Rust packages (wasm-sdk) / Linting
  • GitHub Check: Rust packages (wasm-sdk) / Tests
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
  • GitHub Check: Rust packages (dashpay-contract) / Formatting
  • GitHub Check: Rust packages (dpns-contract) / Linting
  • GitHub Check: Rust packages (dashpay-contract) / Tests
  • GitHub Check: Rust packages (dashpay-contract) / Unused dependencies
  • GitHub Check: Rust packages (drive) / Tests
  • GitHub Check: Rust packages (wallet-utils-contract) / Tests
  • GitHub Check: Rust packages (wallet-utils-contract) / Linting
  • GitHub Check: Rust packages (wallet-utils-contract) / Unused dependencies
  • GitHub Check: Rust packages (wasm-dpp2) / Tests
  • GitHub Check: Rust packages (wasm-sdk) / Linting
  • GitHub Check: Rust packages (wasm-sdk) / Tests
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
  • GitHub Check: Rust packages (dashpay-contract) / Formatting
  • GitHub Check: Rust packages (dpns-contract) / Linting
  • GitHub Check: Rust packages (dashpay-contract) / Tests
  • GitHub Check: Rust packages (dashpay-contract) / Unused dependencies
  • GitHub Check: Rust packages (drive) / Tests
  • GitHub Check: Rust packages (wallet-utils-contract) / Tests
  • GitHub Check: Rust packages (wallet-utils-contract) / Linting
  • GitHub Check: Rust packages (wallet-utils-contract) / Unused dependencies
  • GitHub Check: Rust packages (wasm-dpp2) / Tests
  • GitHub Check: Rust packages (wasm-sdk) / Linting
  • GitHub Check: Rust packages (wasm-sdk) / Tests
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
  • GitHub Check: Rust packages (dashpay-contract) / Detect immutable structure changes
  • GitHub Check: Rust packages (dashpay-contract) / Formatting
  • GitHub Check: Rust packages (dpns-contract) / Linting
  • GitHub Check: Rust packages (dashpay-contract) / Tests
  • GitHub Check: Rust packages (dashpay-contract) / Linting
  • GitHub Check: Rust packages (dashpay-contract) / Unused dependencies
  • GitHub Check: Rust packages (drive) / Tests
  • GitHub Check: Rust packages (wallet-utils-contract) / Tests
  • GitHub Check: Rust packages (wallet-utils-contract) / Linting
  • GitHub Check: Rust packages (wallet-utils-contract) / Unused dependencies
  • GitHub Check: Rust packages (wasm-sdk) / Linting
  • GitHub Check: Rust packages (wasm-sdk) / Tests
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
  • GitHub Check: Rust packages (dashpay-contract) / Detect immutable structure changes
  • GitHub Check: Rust packages (dashpay-contract) / Formatting
  • GitHub Check: Rust packages (dpns-contract) / Linting
  • GitHub Check: Rust packages (dashpay-contract) / Tests
  • GitHub Check: Rust packages (dashpay-contract) / Linting
  • GitHub Check: Rust packages (dashpay-contract) / Unused dependencies
  • GitHub Check: Rust packages (drive) / Tests
  • GitHub Check: Rust packages (wallet-utils-contract) / Tests
  • GitHub Check: Rust packages (wallet-utils-contract) / Linting
  • GitHub Check: Rust packages (wasm-sdk) / Linting
  • GitHub Check: Rust packages (wasm-sdk) / Tests
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
  • GitHub Check: Rust packages (dashpay-contract) / Detect immutable structure changes
  • GitHub Check: Rust packages (dashpay-contract) / Formatting
  • GitHub Check: Rust packages (dpns-contract) / Linting
  • GitHub Check: Rust packages (dashpay-contract) / Tests
  • GitHub Check: Rust packages (dashpay-contract) / Linting
  • GitHub Check: Rust packages (dashpay-contract) / Unused dependencies
  • GitHub Check: Rust packages (drive) / Tests
  • GitHub Check: Rust packages (wallet-utils-contract) / Tests
  • GitHub Check: Rust packages (wallet-utils-contract) / Linting
  • GitHub Check: Rust packages (wasm-sdk) / Linting
  • GitHub Check: Rust packages (wasm-sdk) / Tests
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
  • GitHub Check: Rust packages (dashpay-contract) / Detect immutable structure changes
  • GitHub Check: Rust packages (dashpay-contract) / Formatting
  • GitHub Check: Rust packages (dpns-contract) / Linting
  • GitHub Check: Rust packages (dashpay-contract) / Tests
  • GitHub Check: Rust packages (dashpay-contract) / Linting
  • GitHub Check: Rust packages (dashpay-contract) / Unused dependencies
  • GitHub Check: Rust packages (drive) / Tests
  • GitHub Check: Rust packages (wallet-utils-contract) / Tests
  • GitHub Check: Rust packages (wallet-utils-contract) / Linting
  • GitHub Check: Rust packages (wasm-sdk) / Linting
  • GitHub Check: Rust packages (wasm-sdk) / Tests
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
  • GitHub Check: Rust packages (dashpay-contract) / Detect immutable structure changes
  • GitHub Check: Rust packages (dashpay-contract) / Formatting
  • GitHub Check: Rust packages (dpns-contract) / Linting
  • GitHub Check: Rust packages (dashpay-contract) / Tests
  • GitHub Check: Rust packages (dashpay-contract) / Linting
  • GitHub Check: Rust packages (dashpay-contract) / Unused dependencies
  • GitHub Check: Rust packages (drive) / Tests
  • GitHub Check: Rust packages (wallet-utils-contract) / Tests
  • GitHub Check: Rust packages (wallet-utils-contract) / Linting
  • GitHub Check: Rust packages (wasm-sdk) / Linting
  • GitHub Check: Rust packages (wasm-sdk) / Tests
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
  • GitHub Check: Rust packages (dashpay-contract) / Detect immutable structure changes
  • GitHub Check: Rust packages (dashpay-contract) / Formatting
  • GitHub Check: Rust packages (dpns-contract) / Linting
  • GitHub Check: Rust packages (dashpay-contract) / Tests
  • GitHub Check: Rust packages (dashpay-contract) / Linting
  • GitHub Check: Rust packages (dashpay-contract) / Unused dependencies
  • GitHub Check: Rust packages (drive) / Tests
  • GitHub Check: Rust packages (wallet-utils-contract) / Tests
  • GitHub Check: Rust packages (wallet-utils-contract) / Linting
  • GitHub Check: Rust packages (wasm-sdk) / Linting
  • GitHub Check: Rust packages (wasm-sdk) / Tests
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
🔇 Additional comments (18)
package.json (1)

3-3: Version bump appears correct.

Root package.json version updated to 2.2.0-dev.2. Workspace configuration and all dependencies remain intact.

packages/wasm-dpp2/package.json (1)

3-3: Verify version bump rationale for wasm-dpp2.

This package was bumped to 2.1.0-dev.9, whereas the PR objective states the release targets version 2.2.0-dev.2. Confirm whether wasm-dpp2 intentionally maintains independent versioning or if this should align with the root version.

packages/js-dash-sdk/package.json (1)

3-3: Independent SDK versioning approach is appropriate.

This SDK package maintains its own version track (5.2.0-dev.2). Assuming this is a documented versioning strategy, the bump from 5.2.0-dev.1 to 5.2.0-dev.2 is consistent and correct.

packages/feature-flags-contract/package.json (1)

3-3: Version bump is correct and aligned with release.

Updated to 2.2.0-dev.2 as intended. No other changes required.

packages/wasm-dpp/package.json (1)

3-3: Version bump is correct and aligned with release.

Updated to 2.2.0-dev.2 as intended. No other changes required.

packages/js-evo-sdk/package.json (1)

3-3: Version bump is correct and aligned with release.

Updated to 2.2.0-dev.2 as intended. No other changes required.

packages/wallet-lib/package.json (1)

3-3: Independent wallet library versioning is appropriate.

This mature library maintains its own version track (9.2.0-dev.2). The consistent dev version bump (dev.1 → dev.2) aligns with the overall release pattern.

packages/js-dapi-client/package.json (1)

3-3: Version bump is correct and aligned with release.

Updated to 2.2.0-dev.2 as intended. Workspace dependencies properly configured.

packages/wasm-drive-verify/package.json (1)

6-6: Version bump looks good.

Straightforward version update from 2.2.0-dev.1 to 2.2.0-dev.2 with no other changes to configuration or exports.

packages/wasm-sdk/package.json (1)

3-3: Version bump approved.

Version incremented from 2.2.0-dev.1 to 2.2.0-dev.2 with no changes to dependencies, build scripts, or public API surface.

packages/dpns-contract/package.json (1)

3-3: Version bump is clean.

Updated from 2.2.0-dev.1 to 2.2.0-dev.2 with all test scripts and workspace dependencies preserved.

packages/dapi/package.json (1)

4-4: Version bump is minimal and correct.

Updated to 2.2.0-dev.2 with no changes to the extensive dependency set or test configuration. All workspace references remain consistent.

packages/wallet-utils-contract/package.json (1)

3-3: Version bump looks good.

Updated from 2.2.0-dev.1 to 2.2.0-dev.2 with no changes to test configuration or devDependencies.

packages/dash-spv/package.json (1)

3-3: Verify version number is intentional.

This file bumps to 3.2.0-dev.2 while other monorepo packages (wasm-sdk, dapi, contracts, etc.) are at 2.2.0-dev.2. Confirm whether dash-spv follows separate versioning or if this should align with the 2.2.0 release.

packages/js-grpc-common/package.json (1)

3-3: Version bump is correct.

Updated to 2.2.0-dev.2 with all test thresholds (95% coverage) and dependency specifications preserved.

packages/keyword-search-contract/package.json (1)

3-3: Version bump looks good.

Updated from 2.2.0-dev.1 to 2.2.0-dev.2 with no other changes to configuration or dependencies.

packages/withdrawals-contract/package.json (1)

3-3: Version bump consistent across monorepo.

All version fields across 8 files (package.json and Cargo.toml) are bumped uniformly from 2.2.0-dev.1 to 2.2.0-dev.2, with no functional changes or dependency modifications. Workspace protocol references (workspace:*) remain correct.

packages/dapi-grpc/package.json (1)

3-3: Version bump looks good.

The version is correctly bumped from 2.2.0-dev.1 to 2.2.0-dev.2, consistent with the broader monorepo version bump across the release. Dependencies remain unchanged and properly configured.

Comment on lines +6 to +9
* use identity contract keys query (#2870)
* **sdk:** cleanup JS SDK params and return types (#2858)
* **sdk:** user-friendly evo sdk params (#2856)
* **dashmate:** port conflicts with mainnet and testnet on the same host (#2829)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Standardize issue links in BREAKING CHANGES.

Link numbers like elsewhere in the file for consistency.

Apply:

-* use identity contract keys query (#2870)
-* **sdk:** cleanup JS SDK params and return types (#2858)
-* **sdk:** user-friendly evo sdk params (#2856)
-* **dashmate:** port conflicts with mainnet and testnet  on the same host (#2829)
+* use identity contract keys query ([#2870](https://github.com/dashpay/platform/issues/2870))
+* **sdk:** cleanup JS SDK params and return types ([#2858](https://github.com/dashpay/platform/issues/2858))
+* **sdk:** user-friendly evo sdk params ([#2856](https://github.com/dashpay/platform/issues/2856))
+* **dashmate:** port conflicts with mainnet and testnet on the same host ([#2829](https://github.com/dashpay/platform/issues/2829))
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
* use identity contract keys query (#2870)
* **sdk:** cleanup JS SDK params and return types (#2858)
* **sdk:** user-friendly evo sdk params (#2856)
* **dashmate:** port conflicts with mainnet and testnet on the same host (#2829)
* use identity contract keys query ([#2870](https://github.com/dashpay/platform/issues/2870))
* **sdk:** cleanup JS SDK params and return types ([#2858](https://github.com/dashpay/platform/issues/2858))
* **sdk:** user-friendly evo sdk params ([#2856](https://github.com/dashpay/platform/issues/2856))
* **dashmate:** port conflicts with mainnet and testnet on the same host ([#2829](https://github.com/dashpay/platform/issues/2829))
🤖 Prompt for AI Agents
In CHANGELOG.md around lines 6–9, the BREAKING CHANGES entries use plain
parenthesized issue numbers like "(#2870)" which is inconsistent with the rest
of the file; update each entry to use the same markdown link pattern used
elsewhere in the changelog (i.e., replace the plain "(#NNNN)" tokens with the
repository's markdown link format for PR/issue numbers used in this file),
ensuring all four entries become linked consistently.


### Features

* **dashmate:** add prometheus service discovery labels ([#2818](https://github.com/dashpay/platform/issues/2818))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix extra space.

“add prometheus …” has two spaces.

-* **dashmate:** add  prometheus service discovery labels ([#2818](https://github.com/dashpay/platform/issues/2818))
+* **dashmate:** add prometheus service discovery labels ([#2818](https://github.com/dashpay/platform/issues/2818))
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
* **dashmate:** add prometheus service discovery labels ([#2818](https://github.com/dashpay/platform/issues/2818))
* **dashmate:** add prometheus service discovery labels ([#2818](https://github.com/dashpay/platform/issues/2818))
🤖 Prompt for AI Agents
In CHANGELOG.md around line 13, the bullet "add  prometheus service discovery
labels..." contains an extra space between "add" and "prometheus"; remove the
duplicate space so it reads "add prometheus service discovery labels" and save
the file.


### Bug Fixes

* **dashmate:** port conflicts with mainnet and testnet on the same host ([#2829](https://github.com/dashpay/platform/issues/2829))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove double space.

Double space before “on”.

-* **dashmate:** port conflicts with mainnet and testnet  on the same host ([#2829](https://github.com/dashpay/platform/issues/2829))
+* **dashmate:** port conflicts with mainnet and testnet on the same host ([#2829](https://github.com/dashpay/platform/issues/2829))
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
* **dashmate:** port conflicts with mainnet and testnet on the same host ([#2829](https://github.com/dashpay/platform/issues/2829))
* **dashmate:** port conflicts with mainnet and testnet on the same host ([#2829](https://github.com/dashpay/platform/issues/2829))
🤖 Prompt for AI Agents
In CHANGELOG.md around line 20, there is a double space before the word "on" in
the sentence "* **dashmate:** port conflicts with mainnet and testnet  on the
same host ([#2829](https://github.com/dashpay/platform/issues/2829))"; remove
the extra space so there is only a single space between "testnet" and "on",
keeping the rest of the line unchanged.

### Bug Fixes

* **dashmate:** port conflicts with mainnet and testnet on the same host ([#2829](https://github.com/dashpay/platform/issues/2829))
* **dpp:** desiarilization of data contract JSON with token configuration ([#2857](https://github.com/dashpay/platform/issues/2857))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Typo: “desiarilization” → “deserialization”.

-* **dpp:** desiarilization of data contract JSON with token configuration ([#2857](https://github.com/dashpay/platform/issues/2857))
+* **dpp:** deserialization of data contract JSON with token configuration ([#2857](https://github.com/dashpay/platform/issues/2857))
🤖 Prompt for AI Agents
In CHANGELOG.md around line 21, the word "desiarilization" is misspelled; update
that entry to read "deserialization" (i.e., replace "desiarilization of data
contract JSON with token configuration" with "deserialization of data contract
JSON with token configuration").

@shumkov shumkov merged commit 1ebc168 into v2.2-dev Nov 28, 2025
153 checks passed
@shumkov shumkov deleted the release_2.2.0-dev.2 branch November 28, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants